Fix broken build/push-federation-images.sh#34229
Merged
k8s-github-robot merged 1 commit intokubernetes:masterfrom Oct 6, 2016
Merged
Fix broken build/push-federation-images.sh#34229k8s-github-robot merged 1 commit intokubernetes:masterfrom
k8s-github-robot merged 1 commit intokubernetes:masterfrom
Conversation
Contributor
Author
|
I'm going to self-LGTM here as there is a CI build break that is ongoing. |
3ed99c4 to
7ba1d6d
Compare
This was broken by kubernetes#30787. A stray bash `source` caused an undefined variable reference. Apparently the federation images have a parallel nad different "release" path that isn't tested by the pre-checkin tests.
7ba1d6d to
ce00838
Compare
Contributor
|
Jenkins GCI GKE smoke e2e failed for commit ce00838. Full PR test history. The magic incantation to run this job again is |
Contributor
|
Jenkins GKE smoke e2e failed for commit ce00838. Full PR test history. The magic incantation to run this job again is |
|
Automatic merge from submit-queue |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The federation CI build is broken by #30787. A stray bash
sourcecaused an undefined variable reference.Apparently the federation images have a parallel nad different "release" path that isn't tested by the pre-checkin tests.
This change is