Skip to content

Undelete generated files#29017

Merged
k8s-github-robot merged 3 commits intokubernetes:masterfrom
thockin:undelete-generated-files
Jul 15, 2016
Merged

Undelete generated files#29017
k8s-github-robot merged 3 commits intokubernetes:masterfrom
thockin:undelete-generated-files

Conversation

@thockin
Copy link
Copy Markdown
Member

@thockin thockin commented Jul 15, 2016

There's been enough people broken by not committing generated code, that we
should undo that until we have a proper client that is go get compatible.

This is temporary.

Fixes #28920

thockin added 3 commits July 15, 2016 10:19
@thockin
Fix make to include line-continuations
31badf0
@thockin
Prep to re-commit generated files
ab29a25
@thockin
Commit generated files
3384e03 
There's been enough people broken by not committing generated code, that we
should undo that until we have a proper client that is `go get` compatible.

This is temporary.
@thockin thockin mentioned this pull request Jul 15, 2016
Merged
@caesarxuchao
Copy link
Copy Markdown
Contributor

caesarxuchao commented Jul 15, 2016

Thanks. Not sure about the Makefile changes, the end result looks good.

@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Jul 15, 2016
@thockin thockin added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jul 15, 2016
@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Jul 15, 2016

GCE e2e build/test passed for commit 3384e03.

@bgrant0607
Copy link
Copy Markdown
Member

bgrant0607 commented Jul 15, 2016

LGTM

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2016
@dims
Copy link
Copy Markdown
Member

dims commented Jul 15, 2016

Let's do this! 👍

@thockin thockin added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 15, 2016
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Jul 15, 2016

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Jul 15, 2016

GCE e2e build/test passed for commit 3384e03.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Jul 15, 2016

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit e576a2f into kubernetes:master Jul 15, 2016
@wojtek-t
Copy link
Copy Markdown
Member

wojtek-t commented Aug 10, 2016

@thockin - it's a bit late, but why did we committed only deepcopy files and not autogenerated conversions?

@thockin
Copy link
Copy Markdown
Member Author

thockin commented Aug 11, 2016

eh? Conversions are in this PR...

On Wed, Aug 10, 2016 at 1:15 PM, Wojciech Tyczynski <
notifications@github.com> wrote:

@thockin https://github.com/thockin - it's a bit late, but why did we
committed only deepcopy files and not autogenerated conversions?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#29017 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVMU93qNRtfYSo-H-NwDSOEzhiBTWks5qejFUgaJpZM4JNnyK
.

@wojtek-t
Copy link
Copy Markdown
Member

wojtek-t commented Aug 11, 2016

A sorry - then something must have happened after this PR. Because currently:

  • generated deep-copies are committed to githubs
  • generated conversions aren't
    Is that expected?

@thockin
Copy link
Copy Markdown
Member Author

thockin commented Aug 11, 2016

https://github.com/kubernetes/kubernetes/blob/master/pkg/api/v1/zz_generated.conversion.go

That looks like it is checked in, to me...

On Wed, Aug 10, 2016 at 11:46 PM, Wojciech Tyczynski <
notifications@github.com> wrote:

A sorry - then something must have happened after this PR. Because
currently:

  • generated deep-copies are committed to githubs
  • generated conversions aren't Is that expected?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#29017 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVNvCxgDSlO9hkL3SJ9cE1rEbd8bvks5qesUrgaJpZM4JNnyK
.

@wojtek-t
Copy link
Copy Markdown
Member

wojtek-t commented Aug 11, 2016

ohh - sorry; I must have looked into internal packages...

@thockin
Copy link
Copy Markdown
Member Author

thockin commented Aug 11, 2016

ah, yeah, there were never conversions in internals :)

On Wed, Aug 10, 2016 at 11:54 PM, Wojciech Tyczynski <
notifications@github.com> wrote:

ohh - sorry; I must have looked into internal packages...

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#29017 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFVgVGb4VfKsLZ758G1i0cy9SlU8uN2Wks5qescmgaJpZM4JNnyK
.

@thockin thockin deleted the undelete-generated-files branch November 2, 2016 06:35
@roycaihw roycaihw mentioned this pull request Mar 14, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@caesarxuchao caesarxuchao

@bgrant0607 bgrant0607

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@thockin @caesarxuchao @k8s-bot @bgrant0607 @dims @k8s-github-robot @wojtek-t @googlebot