Rename RBAC 'subject' to 'subjects'.#26924
Rename RBAC 'subject' to 'subjects'.#26924k8s-github-robot merged 2 commits intokubernetes:masterfrom
Conversation
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
2 similar comments
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
|
@ericchiang @erictune I am not 100% sure but it looked like a typo to me when I was trying it out. Since it's still alpha, I assume it's not too late to just rename? |
|
Yes this is a typo. I was going to open the same issue. Seems you beat me to it :) |
|
@k8s-bot ok to test |
|
@olegshaldybin you'll need to regenerate the swagger docs as well. e.g. run ./hack/update-all.sh This will take a while and require sudoless access to the "docker" command. |
d3d42c5 to
69f955f
Compare
|
Rebased and regenerated all. |
|
LGTM, thanks! |
Should be plural 'subjects', assuming singular 'subject' was a typo.
69f955f to
14a6043
Compare
|
Not sure why tests were failing, rebased just in case. |
|
@erictune Can I get another LGTM if tests go green? |
|
This is not going into 1.3-beta. It may be able to go into 1.3.0, I will look into it. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
1 similar comment
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
|
GCE e2e build/test passed for commit 14a6043. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 14a6043. |
|
Automatic merge from submit-queue |
Rename RBAC subject field