Pod eviction grace period flag#25163
Conversation
cmd/kubelet/app/options/options.go
Outdated
There was a problem hiding this comment.
We can only support timeouts in second precision. We can take a duration with that caveat if you think its a must.
There was a problem hiding this comment.
it just makes it easy to express minutes in addition to seconds. FWIW, we have other flags that take duration as well and are most likely using a second granularity underneath.
There was a problem hiding this comment.
We already have grace-period today in the CLI, and it is always seconds. We have stated that things should say "-seconds" in their API. I don't think we make the argument that everything should be duration, just things that that have wildly disparate values.
If this was a duration, we'd have to chop and round it. I'd be ok with that, as long as it translated to seconds throughout the code.
There was a problem hiding this comment.
So this is consistent with --grace-period being in seconds, so keeping as is.
|
Just a couple of comments, otherwise LGTM |
64d6d1c to
d4bc941
Compare
|
hopefully, this is good to go. |
d4bc941 to
6f48499
Compare
6f48499 to
9f077ce
Compare
|
Fixed deep copy generation. |
9f077ce to
9fed0a1
Compare
9fed0a1 to
8032de0
Compare
8032de0 to
12229f3
Compare
|
GCE e2e build/test passed for commit 12229f3. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 12229f3. |
Add the last remaining flag from kubelet eviction proposal.
/cc @vishh