Skip to content

Pod eviction grace period flag#25163

Merged
j3ffml merged 2 commits intokubernetes:masterfrom
derekwaynecarr:pod-eviction-grace-period-flag
May 13, 2016
Merged

Pod eviction grace period flag#25163
j3ffml merged 2 commits intokubernetes:masterfrom
derekwaynecarr:pod-eviction-grace-period-flag

Conversation

@derekwaynecarr
Copy link
Copy Markdown
Member

Add the last remaining flag from kubelet eviction proposal.

/cc @vishh

@derekwaynecarr derekwaynecarr added the release-note-none Denotes a PR that doesn't merit a release note. label May 4, 2016
@derekwaynecarr derekwaynecarr modified the milestones: v1.2, v1.3 May 4, 2016
@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/old-docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2016
@derekwaynecarr derekwaynecarr assigned vishh and unassigned erictune May 4, 2016
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not take in a Duration?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can only support timeouts in second precision. We can take a duration with that caveat if you think its a must.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it just makes it easy to express minutes in addition to seconds. FWIW, we have other flags that take duration as well and are most likely using a second granularity underneath.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have grace-period today in the CLI, and it is always seconds. We have stated that things should say "-seconds" in their API. I don't think we make the argument that everything should be duration, just things that that have wildly disparate values.

If this was a duration, we'd have to chop and round it. I'd be ok with that, as long as it translated to seconds throughout the code.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is consistent with --grace-period being in seconds, so keeping as is.

@vishh
Copy link
Copy Markdown
Contributor

vishh commented May 5, 2016

Just a couple of comments, otherwise LGTM

@derekwaynecarr derekwaynecarr force-pushed the pod-eviction-grace-period-flag branch from 64d6d1c to d4bc941 Compare May 6, 2016 20:21
@derekwaynecarr
Copy link
Copy Markdown
Member Author

hopefully, this is good to go.

@vishh vishh added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2016
@derekwaynecarr derekwaynecarr force-pushed the pod-eviction-grace-period-flag branch from d4bc941 to 6f48499 Compare May 9, 2016 18:07
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 9, 2016
@derekwaynecarr derekwaynecarr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2016
@derekwaynecarr
Copy link
Copy Markdown
Member Author

@k8s-bot test this issue #24620

@derekwaynecarr derekwaynecarr force-pushed the pod-eviction-grace-period-flag branch from 6f48499 to 9f077ce Compare May 10, 2016 23:56
@derekwaynecarr
Copy link
Copy Markdown
Member Author

Fixed deep copy generation.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2016
@derekwaynecarr derekwaynecarr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2016
@derekwaynecarr derekwaynecarr force-pushed the pod-eviction-grace-period-flag branch from 9f077ce to 9fed0a1 Compare May 11, 2016 02:06
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2016
@derekwaynecarr derekwaynecarr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2016
@derekwaynecarr derekwaynecarr force-pushed the pod-eviction-grace-period-flag branch from 9fed0a1 to 8032de0 Compare May 11, 2016 14:37
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2016
@derekwaynecarr derekwaynecarr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2016
@derekwaynecarr derekwaynecarr force-pushed the pod-eviction-grace-period-flag branch from 8032de0 to 12229f3 Compare May 13, 2016 15:44
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 13, 2016
@derekwaynecarr derekwaynecarr added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2016
@k8s-bot
Copy link
Copy Markdown

k8s-bot commented May 13, 2016

GCE e2e build/test passed for commit 12229f3.

@k8s-github-robot
Copy link
Copy Markdown

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented May 13, 2016

GCE e2e build/test passed for commit 12229f3.

@j3ffml j3ffml merged commit 9a20ca2 into kubernetes:master May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants