cri streaming option a hardcut - add new staging repositories `streaming` and `cri-streaming` by dims · Pull Request #137298 · kubernetes/kubernetes

dims · 2026-02-27T21:18:33Z

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

Extracts CRI streaming and shared streaming transport code into dedicated staging modules, while preserving public client-go API compatibility for downstream users.

Adds new staging module k8s.io/cri-streaming
- CRI exec/attach/portforward server implementation, request cache, server wiring, and tests.
Adds new staging module k8s.io/streaming
- canonical home for shared transport primitives: httpstream, spdy, wsstream, and runtime helpers.
Switches in-tree transport consumers to k8s.io/streaming
- includes client-go, apiserver, kubectl, kube-aggregator, e2e/framework callers, and related tests.
Removes in-tree kubelet CRI streaming package (staging/src/k8s.io/kubelet/pkg/cri/streaming).
Preserves NO_PROXY/no_proxy CIDR behavior in the extracted SPDY roundtripper default proxier.
Adds deprecated compatibility wrappers in k8s.io/apimachinery/pkg/util/httpstream (httpstream, spdy, wsstream) backed by k8s.io/streaming for external users.
Restores exported client-go SPDY/portforward API signatures to k8s.io/apimachinery/pkg/util/httpstream types to avoid downstream breakage.
Adds streaming-native client-go adapters/constructors (spdy + portforward) so in-tree callers can use k8s.io/streaming types directly while compatibility signatures remain stable.
Deduplicates SPDY-over-websocket dial negotiation shared by compat and streaming tunneling dialers.
Adds logging for dropped unknown stream types in RemoveStreams adapter fallbacks to improve compatibility-path debuggability.
Adds integration coverage for the streaming-upgrader-to-client-go-compat adapter path against a real cri-streaming exec endpoint.
Clarifies kubectl streaming import aliasing to avoid httpstream package ambiguity.
Removes unused deprecated staging/src/k8s.io/apiserver/pkg/util/wsstream/legacy.go.
Updates import restrictions, staging publishing metadata, and module/workspace/vendor metadata.

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

This PR is intentionally a single squashed commit.
Compatibility decision: k8s.io/apimachinery/pkg/util/httpstream remains as deprecated wrapper APIs for external consumers; in-tree callers are migrated to k8s.io/streaming.

Does this PR introduce a user-facing change?

Introduces new staging modules `k8s.io/streaming` and `k8s.io/cri-streaming` for Kubernetes streaming transport and CRI streaming server code.

`k8s.io/apimachinery/pkg/util/httpstream` (including `spdy` and `wsstream`) remains available as a deprecated compatibility wrapper backed by `k8s.io/streaming`.

The extracted SPDY roundtripper preserves CIDR matching in `NO_PROXY`/`no_proxy`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

N/A

k8s-ci-robot · 2026-02-27T21:18:43Z

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dims · 2026-03-01T13:57:10Z

/test pull-kubernetes-unit

dims · 2026-03-01T14:14:29Z

/skip

dims · 2026-03-01T16:30:33Z

/skip

dims · 2026-03-06T21:23:57Z

/test pull-kubernetes-integration
/test pull-kubernetes-unit-windows-master

Extract streaming code into dedicated staging modules while keeping stable compatibility APIs for external client-go consumers. This commit: - adds `k8s.io/cri-streaming` for CRI exec/attach/portforward server code - adds `k8s.io/streaming` as the canonical home for shared transport primitives (`httpstream`, `spdy`, `wsstream`, runtime helpers) - switches in-tree transport consumers to `k8s.io/streaming` - removes in-tree kubelet CRI streaming package - preserves NO_PROXY/no_proxy CIDR handling in extracted SPDY proxier logic - adds deprecated `k8s.io/apimachinery/pkg/util/httpstream` compatibility wrappers (`httpstream`, `spdy`, `wsstream`) backed by `k8s.io/streaming` - restores exported client-go SPDY/portforward API signatures to apimachinery `httpstream` types for downstream compatibility - adds streaming-native client-go adapters/constructors so in-tree callers can use `k8s.io/streaming` without changing external compatibility APIs - deduplicates SPDY-over-websocket dial negotiation shared by compat and streaming tunneling dialers - logs dropped unknown stream types in `RemoveStreams` adapter fallbacks to improve compatibility-path debuggability - adds integration coverage for the streaming-upgrader-to-client-go-compat adapter path against a real cri-streaming exec endpoint - clarifies kubectl streaming import aliasing to avoid `httpstream` package ambiguity - updates tests, import restrictions, publishing metadata, and vendor/module metadata for the new staging modules Signed-off-by: Davanum Srinivas <davanum@gmail.com>

Remove github.com/stretchr/testify from k8s.io/streaming's test files. testify's assert/yaml subpackage pulls in gopkg.in/yaml.v3, whose test dependencies (gopkg.in/check.v1 → kr/pretty → rogpeppe/go-internal) were propagating into k8s.io/apimachinery and k8s.io/api via the streaming dependency. Removes stretchr/testify, gopkg.in/yaml.v3, gopkg.in/check.v1, github.com/kr/pretty, and github.com/rogpeppe/go-internal from streaming/go.mod. Signed-off-by: Davanum Srinivas <davanum@gmail.com>

Signed-off-by: Davanum Srinivas <davanum@gmail.com>

dims · 2026-03-12T15:12:19Z

/test pull-publishing-bot-validate

dims · 2026-03-12T15:50:57Z

/test pull-publishing-bot-validate

Signed-off-by: Davanum Srinivas <davanum@gmail.com>

dims · 2026-03-12T16:00:44Z

/assign @seans3 @aojea @liggitt @mikebrow @haircommander @tallclair

/hold for reviews

k8s-ci-robot · 2026-03-12T16:49:03Z

@dims: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-publishing-bot-validate	`b3c1418`	link	false	`/test pull-publishing-bot-validate`
pull-kubernetes-linter-hints	`b3c1418`	link	false	`/test pull-kubernetes-linter-hints`
pull-kubernetes-unit-windows-master	`b3c1418`	link	false	`/test pull-kubernetes-unit-windows-master`
pull-kubernetes-e2e-storage-kind-disruptive	`b3c1418`	link	false	`/test pull-kubernetes-e2e-storage-kind-disruptive`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

dims · 2026-03-12T17:44:05Z

/skip

SergeyKanzhelev · 2026-03-12T21:53:10Z

/lgtm

it will be great to merge soon so we have some time to try to use it from from cri-tool repo or similar to see if we missed anything before code freeze.

k8s-ci-robot · 2026-03-12T21:53:19Z

LGTM label has been added.

Details

Git tree hash: 30677cad00596f4cf183211a2ab8e155130f5a10

dims · 2026-03-12T22:13:58Z

@SergeyKanzhelev let me wait for the beta.0 cut to wrap up today/early tomorrow - https://kubernetes.slack.com/archives/CJH2GBF7Y/p1773342173228169 and then remove hold on this. there are probably a few more things to tweak, don't want to destabilize the release process by landing this now.

dims · 2026-03-13T11:01:59Z

Looks like the release process is stuck! https://kubernetes.slack.com/archives/CJH2GBF7Y/p1773351611764119?thread_ts=1773342173.228169&cid=CJH2GBF7Y

will go ahead and land this.

/hold cancel

akhilerm · 2026-03-13T13:38:12Z

@dims The publishing fails after merging this with

	+ echo 'Packaging up pseudo version v0.0.0-20260312143435-6759320cdb61 into go mod cache...'
	+ mkdir -p /go-workspace/pkg/mod/cache/download/k8s.io/streaming/@v
	+ cp go.mod /go-workspace/pkg/mod/cache/download/k8s.io/streaming/@v/v0.0.0-20260312143435-6759320cdb61.mod
	cp: cannot stat 'go.mod': No such file or directory

Did we miss some step while creating the new staging repo for streaming?

dims · 2026-03-13T13:58:21Z

@akhilerm let's try fixing repos.sh in publishing-bot? like dims/publishing-bot@361246e

k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 27, 2026

k8s-ci-robot requested review from a team, cpanato and derekwaynecarr February 27, 2026 21:18

github-project-automation Bot added this to SIG Node CI/Test Board and SIG Node: code and documentation PRs Feb 27, 2026

k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 27, 2026

github-project-automation Bot moved this to Triage in SIG Node: code and documentation PRs Feb 27, 2026

github-project-automation Bot moved this to Triage in SIG Node CI/Test Board Feb 27, 2026

k8s-ci-robot added the wg/device-management Categorizes an issue or PR as relevant to WG Device Management. label Feb 27, 2026

github-project-automation Bot added this to Dynamic Resource Allocation Feb 27, 2026

github-project-automation Bot moved this to 🆕 New in Dynamic Resource Allocation Feb 27, 2026

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 27, 2026

dims mentioned this pull request Mar 6, 2026

REQUEST: Create 2 new Staging repos - streaming and cri-streaming kubernetes/org#6189

Closed

aojea reviewed Mar 6, 2026

View reviewed changes

Comment thread staging/src/k8s.io/streaming/OWNERS

aojea reviewed Mar 6, 2026

View reviewed changes

Comment thread staging/publishing/import-restrictions.yaml

aojea reviewed Mar 6, 2026

View reviewed changes

Comment thread staging/src/k8s.io/api/go.mod Outdated

dims added 4 commits March 12, 2026 09:59

fixup: remove unused klog import; drop rogpeppe from apimachinery

66f4906

Signed-off-by: Davanum Srinivas <davanum@gmail.com>

staging: update OWNERS for cri-streaming and streaming modules

fdfffef

Signed-off-by: Davanum Srinivas <davanum@gmail.com>

staging/publishing: order streaming before dependents

b3c1418

Signed-off-by: Davanum Srinivas <davanum@gmail.com>

This was referenced Mar 13, 2026

add new streaming and cri-streaming repos kubernetes/publishing-bot#544

Merged

remove streaming as a dependency of kms repo #137736

Merged

brandond mentioned this pull request Apr 29, 2026

kubectl exec on pod is returning error on exec when docker: true k3s-io/k3s#14017

Closed

sxd mentioned this pull request May 2, 2026

chore: update to Kubernetes 0.36.0 cloudnative-pg/cloudnative-pg#10593

Merged

anshulg-dep-review Bot mentioned this pull request May 24, 2026

Update rancher/k3s-upgrade Docker digest to e54a34f ansg191-lab/anshulg-cluster#3198

Open

1 task

coderabbitai Bot mentioned this pull request May 28, 2026

chore(deps): bump the kubernetes group across 1 directory with 4 updates openshift/rbac-permissions-operator#351

Closed

Conversation

dims commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Feb 27, 2026

Uh oh!

dims commented Mar 1, 2026

Uh oh!

dims commented Mar 1, 2026

Uh oh!

dims commented Mar 1, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dims commented Mar 6, 2026

Uh oh!

dims commented Mar 12, 2026

Uh oh!

dims commented Mar 12, 2026

Uh oh!

dims commented Mar 12, 2026

Uh oh!

k8s-ci-robot commented Mar 12, 2026

Uh oh!

dims commented Mar 12, 2026

Uh oh!

SergeyKanzhelev commented Mar 12, 2026

Uh oh!

k8s-ci-robot commented Mar 12, 2026

Uh oh!

dims commented Mar 12, 2026

Uh oh!

dims commented Mar 13, 2026

Uh oh!

akhilerm commented Mar 13, 2026

Uh oh!

dims commented Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

dims commented Feb 27, 2026 •

edited

Loading