Skip to content

Emit an event when the result of a probe for a container changes#135401

Open
Maxim-Durand wants to merge 3 commits intokubernetes:masterfrom
Maxim-Durand:annotate-container-events-emitted-by-probes-with-failure-thresholds
Open

Emit an event when the result of a probe for a container changes#135401
Maxim-Durand wants to merge 3 commits intokubernetes:masterfrom
Maxim-Durand:annotate-container-events-emitted-by-probes-with-failure-thresholds

Conversation

@Maxim-Durand
Copy link

@Maxim-Durand Maxim-Durand commented Nov 22, 2025 •
edited
Loading

/sig node

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

This PR introduces a new event that is emitted by the probe worker when the result of the probe changes. End-users can watch this new event to learn when their probes entered the Sucess or Failure state and in the case of Failure they gain some contextual information in the form of the output from the last probe.

Which issue(s) this PR is related to:

Fixes #115823 by dealing with the lack of information on when a probe fails (as users can now just look at this event)

Special notes for your reviewer:

This is revival of #115963 as requested in #115823 (comment)
The original PR passed most of the review process but wasn't kept updated enough to merge in the end.
This PR is a faithful copy of the original one on top of the latest master branch (the original PR being 2 years old).

Does this PR introduce a user-facing change?

Yes

A new event is emitted on containers when their readiness, liveness or startup probes change result from Success to Failure or vice-versa. In the case of Failure information on why the probe failed may be included.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 22, 2025
@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Nov 22, 2025
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 22, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 22, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 22, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 22, 2025

Hi @Maxim-Durand. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 22, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Maxim-Durand
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubelet do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 22, 2025
@Maxim-Durand Maxim-Durand marked this pull request as ready for review November 22, 2025 15:16
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2025
@Maxim-Durand Maxim-Durand changed the title Faithful copy of https://github.com/kubernetes/kubernetes/pull/115963 Give an indication in container events for probe failure as to whether the failure was ignored due to FailureThreshold Nov 22, 2025
@Maxim-Durand Maxim-Durand changed the title Give an indication in container events for probe failure as to whether the failure was ignored due to FailureThreshold Emit an event when the result of a probe for a container changes Nov 22, 2025
@Maxim-Durand Maxim-Durand mentioned this pull request Nov 22, 2025
Open
@Maxim-Durand Maxim-Durand force-pushed the annotate-container-events-emitted-by-probes-with-failure-thresholds branch from 89f9d50 to bdde2c3 Compare November 22, 2025 15:28
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Nov 22, 2025
@Maxim-Durand
Copy link
Author

Maxim-Durand commented Nov 22, 2025

Force pushed to rebase from latest master

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 24, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@haircommander haircommander moved this from Triage to Waiting on Author in SIG Node: code and documentation PRs Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims Awaiting requested review from dims

@natasha41575 natasha41575 Awaiting requested review from natasha41575

@rphillips rphillips Awaiting requested review from rphillips

@wzshiming wzshiming Awaiting requested review from wzshiming

Assignees

No one assigned

Labels

area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

SIG Node: code and documentation PRs
Status: Waiting on Author

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Give an indication in container events for probe failure as to whether the failure was ignored due to FailureThreshold

2 participants

@Maxim-Durand @k8s-ci-robot