Skip to content

hack/local-up-cluster.sh: remove kubelet --cloud-config#131841

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
pohly:local-up-cluster-cloud-config-fix
May 19, 2025
Merged

hack/local-up-cluster.sh: remove kubelet --cloud-config#131841
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
pohly:local-up-cluster-cloud-config-fix

Conversation

@pohly
Copy link
Copy Markdown
Contributor

@pohly pohly commented May 19, 2025

What type of PR is this?

/kind bug
/kind failing-test

What this PR does / why we need it:

c0b2f34 (#130161) removed that flag, which was already deprecated earlier. When passing it now, kubelet fails to come up.

Which issue(s) this PR fixes:

Fixes #130161 (comment)

Does this PR introduce a user-facing change?

NONE

/assign @carlory

@pohly
hack/local-up-cluster.sh: remove kubelet --cloud-config
d3afe8a 
c0b2f34 removed that flag, which was already
deprecated earlier. When passing it now, kubelet fails to come up.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 19, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 19, 2025

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 19, 2025
@pohly pohly mentioned this pull request May 19, 2025
Merged
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2025
@k8s-ci-robot k8s-ci-robot requested review from liggitt and wojtek-t May 19, 2025 07:22
@carlory
Copy link
Copy Markdown
Member

carlory commented May 19, 2025

/lgtm
/test pull-kubernetes-e2e-kind

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 19, 2025

LGTM label has been added.

DetailsGit tree hash: 10c7ed62ddd72544368370b79d663e51365670ad

@dims
Copy link
Copy Markdown
Member

dims commented May 19, 2025

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit fc3e0cf into kubernetes:master May 19, 2025
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@carlory carlory

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.34

Development

Successfully merging this pull request may close these issues.

4 participants

@pohly @k8s-ci-robot @carlory @dims