Skip to content

Omit null creationTimestamp#130989

Merged
k8s-ci-robot merged 5 commits intokubernetes:masterfrom
liggitt:creationTimestamp-omitzero
May 2, 2025
Merged

Omit null creationTimestamp#130989
k8s-ci-robot merged 5 commits intokubernetes:masterfrom
liggitt:creationTimestamp-omitzero

Conversation

@liggitt
Copy link
Copy Markdown
Member

@liggitt liggitt commented Mar 21, 2025 •
edited
Loading

Fixes #67610

Zero-value `metadata.creationTimestamp` values are now omitted and no longer serialize an explicit `null` in JSON, YAML, and CBOR output

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm area/kubectl area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 21, 2025
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Mar 21, 2025
@k8s-ci-robot k8s-ci-robot requested review from aojea and apelisse March 21, 2025 19:10
@k8s-ci-robot k8s-ci-robot added the sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. label Mar 21, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Mar 21, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Auth Mar 21, 2025
deads2k
deads2k reviewed May 2, 2025
View reviewed changes
staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/types.go
// More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
// +optional
CreationTimestamp Time `json:"creationTimestamp,omitempty" protobuf:"bytes,8,opt,name=creationTimestamp"`
CreationTimestamp Time `json:"creationTimestamp,omitempty,omitzero" protobuf:"bytes,8,opt,name=creationTimestamp"`
Copy link
Copy Markdown
Contributor

@deads2k deads2k May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this new or did we simply miss it all that time ago?

Copy link
Copy Markdown
Member Author

@liggitt liggitt May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New in go 1.23ish

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented May 2, 2025

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 2, 2025

LGTM label has been added.

DetailsGit tree hash: 84443b4a821459770f9523c7cdbcfe8a6dd27a1e

@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented May 2, 2025

rebased on #131029 and fixed vendor conflict errors

@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented May 2, 2025

/hold for #131029 merge

@liggitt liggitt mentioned this pull request May 2, 2025
Closed
@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented May 2, 2025

flake on #129802

rebased after #131029 merge

/hold cancel

@liggitt liggitt mentioned this pull request May 2, 2025
Closed
@liggitt
Copy link
Copy Markdown
Member Author

liggitt commented May 2, 2025

/retest

@jpbetz
Copy link
Copy Markdown
Contributor

jpbetz commented May 2, 2025

/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 2, 2025

LGTM label has been added.

DetailsGit tree hash: afd54ab17edb1fa2fb5c1b5c028da5af843e1d6c

@jpbetz jpbetz mentioned this pull request May 3, 2025
Merged
@jpbetz jpbetz mentioned this pull request May 28, 2025
Closed
@alvaroaleman alvaroaleman mentioned this pull request Jun 3, 2025
Merged
@sbueringer sbueringer mentioned this pull request Jun 5, 2025
Closed
20 tasks
@sbueringer sbueringer mentioned this pull request Jul 18, 2025
Merged
@sbueringer sbueringer mentioned this pull request Aug 28, 2025
Closed
29 tasks
@barney-s barney-s mentioned this pull request Aug 29, 2025
Merged
@alban alban mentioned this pull request Sep 1, 2025
Merged
@czeslavo czeslavo mentioned this pull request Sep 15, 2025
Closed
@fristonio fristonio mentioned this pull request Oct 16, 2025
Closed
@RainbowMango RainbowMango mentioned this pull request Oct 24, 2025
Closed
15 tasks
@barkbay barkbay mentioned this pull request Nov 4, 2025
Closed
@sbueringer sbueringer mentioned this pull request Dec 18, 2025
Open
19 tasks
@snarkychef snarkychef mentioned this pull request Jan 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aojea aojea Awaiting requested review from aojea

@apelisse apelisse Awaiting requested review from apelisse

@jpbetz jpbetz Awaiting requested review from jpbetz

@deads2k deads2k Awaiting requested review from deads2k

2 more reviewers

@benluddy benluddy benluddy left review comments

@hashim21223445 hashim21223445 hashim21223445 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jpbetz jpbetz

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kube-proxy area/kubeadm area/kubectl area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.

Projects

API Reviews
Status: API review completed, 1.34
Dynamic Resource Allocation
Archived in project
SIG Apps
Archived in project
SIG Auth
Archived in project
SIG CLI
Archived in project
SIG Node CI/Test Board
Archived in project

Milestone

v1.34

Development

Successfully merging this pull request may close these issues.

Avoid serializing creationTimestamp: null