Skip to content

KEP-5040: Disable git_repo volume driver.#129923

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
vinayakankugoyal:gitRepo
Mar 15, 2025
Merged

KEP-5040: Disable git_repo volume driver.#129923
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
vinayakankugoyal:gitRepo

Conversation

@vinayakankugoyal

@vinayakankugoyal vinayakankugoyal commented Jan 31, 2025 •
edited by thockin
Loading

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

As part of KEP-5040 this PR disables the gitRepo volume plugin by default. However users who are still using this feature can enable gitRepo volume plugin setting the feature-gate GitRepoVolumeDriver=true in kubelet feature-gates.

Which issue(s) this PR fixes:

Fixes #125983

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Disabled git-repo volume plugin by default, with the option to turn it back on by setting feature-gate GitRepoVolumeDriver=true.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/5040

@k8s-ci-robot

k8s-ci-robot commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 31, 2025
@k8s-ci-robot

k8s-ci-robot commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 31, 2025
@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 31, 2025
Charlesnorris509

This comment was marked as off-topic.

Sign in to view

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 7, 2025
@vinayakankugoyal vinayakankugoyal mentioned this pull request Feb 7, 2025
Open
14 tasks
@vinayakankugoyal

vinayakankugoyal commented Feb 7, 2025

Copy link
Copy Markdown
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 7, 2025
@vinayakankugoyal vinayakankugoyal marked this pull request as ready for review February 7, 2025 22:36
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2025
@vinayakankugoyal

vinayakankugoyal commented Feb 7, 2025

Copy link
Copy Markdown
Contributor Author

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 7, 2025
@k8s-ci-robot k8s-ci-robot requested a review from saad-ali March 14, 2025 15:29
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2025
@xing-yang

xing-yang commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2025
@k8s-ci-robot

k8s-ci-robot commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 5230f30d38d3d3bc9c43aa1b20abc65710f98100

thockin
thockin reviewed Mar 14, 2025
View reviewed changes

@thockin thockin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this before

Comment thread pkg/features/versioned_kube_features.go Outdated
Comment thread test/compatibility_lifecycle/reference/versioned_feature_list.yaml Outdated
@xing-yang

xing-yang commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2025
@thockin thockin self-assigned this Mar 14, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2025
@thockin

thockin commented Mar 14, 2025

Copy link
Copy Markdown
Member

Thanks!

/lgtm
/approve

@xing-yang - what the reason for the hold?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2025
@k8s-ci-robot

k8s-ci-robot commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: f678588012418c753918de60b39fee8bb496ecd8

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2025
@thockin

thockin commented Mar 14, 2025

Copy link
Copy Markdown
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2025
@k8s-ci-robot

k8s-ci-robot commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 427ecd908c7260c5bb00b2a6714bd890fce63006

@k8s-ci-robot

k8s-ci-robot commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali, thockin, vinayakankugoyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot

k8s-ci-robot commented Mar 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@vinayakankugoyal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-kind-alpha-beta-features 282e149 link false /test pull-kubernetes-e2e-kind-alpha-beta-features

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xing-yang

xing-yang commented Mar 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

/hold cancel

@thockin You added new comments after I gave "lgtm":). I just want to make sure those are addressed before the PR is merged.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8de738e into kubernetes:master Mar 15, 2025
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Mar 15, 2025
@vinayakankugoyal vinayakankugoyal mentioned this pull request Mar 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@danwinship danwinship Awaiting requested review from danwinship

@liggitt liggitt Awaiting requested review from liggitt

@saad-ali saad-ali Awaiting requested review from saad-ali

@thockin thockin Awaiting requested review from thockin

@xing-yang xing-yang Awaiting requested review from xing-yang

1 more reviewer

@Charlesnorris509 Charlesnorris509 Charlesnorris509 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@xing-yang xing-yang

@thockin thockin

@saad-ali saad-ali

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.33

Development

Successfully merging this pull request may close these issues.

Remove gitRepo volume type

7 participants

@vinayakankugoyal @k8s-ci-robot @xing-yang @thockin @liggitt @saad-ali @Charlesnorris509