DRA: CEL cost estimate during validation#129749
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Jan 23, 2025
Merged
DRA: CEL cost estimate during validation#129749k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
Compiling a CEL expression used to do the cost estimation, whether the caller needed the result or not. Now callers can skip it. The scheduler does that, through the CEL cache. The main advantage is that failures in the estimator (like panics) are limited to the apiserver. Performance in the scheduler is not expected to benefit much because compilation results are cached.
978590a to
d889bd1
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/triage accepted |
Contributor
Author
|
/assign @jpbetz |
Contributor
|
/lgtm |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 2dd16656f186c6ac7f3043485c9ae851be5aa073 |
41 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Compiling a CEL expression used to do the cost estimation, whether the caller needed the result or not. Now callers can disable it and that is done by the code which runs in the scheduler.
The main advantage is that failures in the estimator (like panics) are limited to the apiserver. Performance in the scheduler is not expected to benefit much because compilation results are cached.
Which issue(s) this PR fixes:
Related-to: #129690 (comment)
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: