Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

The committers listed above are authorized under a signed CLA.

• ✅ login: vivzbansal / name: Vivek Bansal (cd3d10f, 4a39660, 912d241, 31efae4, 8a2a35d, 25dc6d2, 8ddac5b, 5af7dc8, d6ce1d4, 28684f0, a45a153, c27c966, 80b0e52, c6490c6, 4c46646, 4e9e14b, 88d5a6b, 4cf2e7c, 876aac3)

Welcome @vivzbansal!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @vivzbansal. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

/assign @SergeyKanzhelev

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vivzbansal
Once this PR has been reviewed and has the lgtm label, please ask for approval from sergeykanzhelev and additionally assign deads2k, huang-wei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

/remove-sig api-machinery
/sig architecture

Few nits:

1. add a release note - sidecar containers now support in-place pod vertical scaling
2. It would be good to remove merge commits.

/ok-to-test

PR needs rebase.

@vivzbansal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

I didn't get through the whole review, but left some comments. A lot of this code will actually get simplified if #128269 merges, and I'm wondering if it's better to hold off for that at this point?

There are many merge conflicts in this PR due to #128269 (also some of the core logic is changed in it), so I have created another PR #128367 and closing this one out.

/triage accepted