This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

big +1 for getting test coverage in place for all the combinations of explicit / auto-detected --node-ip, explicit / auto-detected --hostname-override, and external / no cloud provider.

Can you see what these do prior to #121028 and prior to #124516?

I think (but have not had time to dig in and verify) that #124516 regressed how kubelet requests CSRs on startup in some configurations (#124554 (comment)) and I'm super wary of locking in that unreleased behavior in a unit test.

Oh, I misread the PR :)

I thought this was testing kubelet address reporting behavior.

I think (but have not had time to dig in and verify) that #124516 regressed how kubelet requests CSRs on startup in some configurations (#124554 (comment)) and I'm super wary of locking in that unreleased behavior in a unit test.

will follow up on that, this is just to be sure the hostname behavior is tested so we can prevent regressions

I think (but have not had time to dig in and verify) that #124516 regressed how kubelet requests CSRs on startup in some configurations

124516 is supposed to just be bringing back the pre-1.29 behavior. I don't think that's where the regression came from.

EDIT: ok, it is. Fixed by #125813

this looks good to me, i am unfamiliar with the error coming from pull-kubernetes-integration, is that related to this change?

this looks good to me, i am unfamiliar with the error coming from pull-kubernetes-integration, is that related to this change?

does not seem related

{Failed; === RUN TestWebhookConverterWithWatchCache

/test pull-kubernetes-integration

/assign @cheftako

can you please approve?

/lgtm
/approve

Thanks for adding this Antonio

LGTM label has been added.

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, cheftako

The full list of commands accepted by this bot can be found here.

The pull request process is described here