Skip to content

Promote RetryGenerateName to beta#124673

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
jpbetz:retry-beta
May 6, 2024
Merged

Promote RetryGenerateName to beta#124673
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
jpbetz:retry-beta

Conversation

@jpbetz

@jpbetz jpbetz commented May 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Promoted `generateName` retries to beta, and made the `NameGenerationRetries` feature gate
enabled by default.
You can read https://kep.k8s.io/4420 for more details.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig api-machinery
/milestone v1.31

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 2, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 2, 2024
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 2, 2024
@jpbetz

jpbetz commented May 2, 2024

Copy link
Copy Markdown
Contributor Author

/assign @deads2k
This is just a feature gate flip.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2024
@k8s-ci-robot k8s-ci-robot requested review from apelisse and thockin May 2, 2024 13:31
@jpbetz jpbetz mentioned this pull request May 2, 2024
Closed
12 tasks
@cici37

cici37 commented May 2, 2024

Copy link
Copy Markdown
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 2, 2024
@k8s-ci-robot

k8s-ci-robot commented May 3, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k

deads2k commented May 6, 2024

Copy link
Copy Markdown
Contributor

matches expectations

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2024
@k8s-ci-robot

k8s-ci-robot commented May 6, 2024

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: cd1c3efa859ac2d0a6abb44d7cea67fcfb1290ed

@k8s-ci-robot k8s-ci-robot merged commit 54687f3 into kubernetes:master May 6, 2024
@sftim

sftim commented May 7, 2024

Copy link
Copy Markdown
Contributor

Changelog suggestion

-GenerateName retry is now in beta and enabled by default. Check out https://github.com/kubernetes/enhancements/issues/4420 for more details.
+Promoted `generateName` retries to beta, and made the `NameGenerationRetries` feature gate
+enabled by default.
+You can read https://kep.k8s.io/4420 for more details.

@sftim

sftim commented May 7, 2024

Copy link
Copy Markdown
Contributor

When we document this change, let's update https://kubernetes.io/docs/reference/using-api/api-concepts/#generated-values with a brief mention of retries.

@jpbetz

jpbetz commented May 7, 2024

Copy link
Copy Markdown
Contributor Author

When we document this change, let's update https://kubernetes.io/docs/reference/using-api/api-concepts/#generated-values with a brief mention of retries.

Will do. Thanks Tim for you helping get this one done early in the cycle!

@Jefftree Jefftree mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apelisse apelisse Awaiting requested review from apelisse

@thockin thockin Awaiting requested review from thockin

Assignees

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.31

Development

Successfully merging this pull request may close these issues.

5 participants

@jpbetz @cici37 @k8s-ci-robot @deads2k @sftim