Skip to content

graduate MatchLabelKeysInPodAffinity to Beta#123638

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
sanposhiho:matchlabelkey-beta
May 13, 2024
Merged

graduate MatchLabelKeysInPodAffinity to Beta#123638
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
sanposhiho:matchlabelkey-beta

Conversation

@sanposhiho
Copy link
Copy Markdown
Member

@sanposhiho sanposhiho commented Mar 2, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • graduate MatchLabelKeysInPodAffinity to Beta
  • add the feature gate switching test.

Which issue(s) this PR fixes:

Fixes #123156
Part of kubernetes/enhancements#3633

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Graduate MatchLabelKeys/MismatchLabelKeys feature in PodAffinity/PodAntiAffinity to Beta

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/3633

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 2, 2024
@k8s-ci-robot k8s-ci-robot requested review from denkensk and thockin March 2, 2024 05:50
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 2, 2024
@sanposhiho
Copy link
Copy Markdown
Member Author

sanposhiho commented Mar 2, 2024

/cc @alculquicondor @Huang-Wei

@k8s-ci-robot k8s-ci-robot added area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Mar 2, 2024
@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Mar 2, 2024

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@sanposhiho
Copy link
Copy Markdown
Member Author

sanposhiho commented Mar 2, 2024

/retest
#123621

@sanposhiho sanposhiho mentioned this pull request Mar 2, 2024
Closed
12 tasks
sanposhiho
sanposhiho commented Mar 4, 2024
View reviewed changes
Comment thread test/integration/scheduler/filters/filters_test.go

// TestPodAffinityMatchLabelKeyEnablement tests the Pod is correctly mutated by MatchLabelKeysInPodAffinity feature,
// even if turing the feature gate enabled or disabled.
func TestPodAffinityMatchLabelKeyEnablement(t *testing.T) {
Copy link
Copy Markdown
Member Author

@sanposhiho sanposhiho Mar 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same is tested manually in a real cluster (kind) too, as suggested here: kubernetes/enhancements#4450 (comment)

alculquicondor
alculquicondor reviewed Mar 5, 2024
View reviewed changes
Comment thread staging/src/k8s.io/api/core/v1/types.go
alculquicondor
alculquicondor reviewed Mar 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Mar 5, 2024
@alculquicondor
Copy link
Copy Markdown
Member

alculquicondor commented Mar 5, 2024

/assign @deads2k
for API, as alpha reviewer.

@sanposhiho sanposhiho force-pushed the matchlabelkey-beta branch from ba1b795 to b7761d1 Compare March 5, 2024 14:42
@sanposhiho
Copy link
Copy Markdown
Member Author

sanposhiho commented Mar 5, 2024

/retest

@jiahuif
Copy link
Copy Markdown
Contributor

jiahuif commented Mar 12, 2024

/remove-sig api-machinery
/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Mar 12, 2024
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented May 10, 2024

API change looks good. Integration test looks good. I strongly encourage writing a positive e2e test that could be (but doesn't necessarily need to be) made a conformance test in the future.

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, deads2k, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
@alculquicondor
Copy link
Copy Markdown
Member

alculquicondor commented May 10, 2024

@sanposhiho I guess we need to update the KEP for 1.31 now

@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented May 10, 2024

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

4 similar comments
@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented May 10, 2024

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented May 11, 2024

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented May 11, 2024

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented May 11, 2024

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@sanposhiho sanposhiho force-pushed the matchlabelkey-beta branch from b7761d1 to a825899 Compare May 11, 2024 10:26
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2024
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 11, 2024
@sanposhiho sanposhiho force-pushed the matchlabelkey-beta branch from a825899 to 2ea7d8f Compare May 11, 2024 10:40
@sanposhiho
Copy link
Copy Markdown
Member Author

sanposhiho commented May 11, 2024

/retest

@sanposhiho
Copy link
Copy Markdown
Member Author

sanposhiho commented May 11, 2024

Made KEP update in kubernetes/enhancements#4627.

@alculquicondor @deads2k
I had to rebase the PR upon the master branch to fix the test failure. Please give it lgtm again when have time.

@alculquicondor
Copy link
Copy Markdown
Member

alculquicondor commented May 13, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 13, 2024

LGTM label has been added.

DetailsGit tree hash: f4cf215b7360eea9f6697b591b55eb43c7eba06e

@k8s-ci-robot k8s-ci-robot merged commit 8ac9d94 into kubernetes:master May 13, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 13, 2024
@fedebongio
Copy link
Copy Markdown
Contributor

fedebongio commented May 14, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 14, 2024
@ialidzhikov ialidzhikov mentioned this pull request Aug 29, 2024
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denkensk denkensk Awaiting requested review from denkensk

@thockin thockin Awaiting requested review from thockin

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@alculquicondor alculquicondor

@deads2k deads2k

Labels

api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

API Reviews
Status: API review completed, 1.31
SIG Apps
Archived in project

Milestone

v1.31

Development

Successfully merging this pull request may close these issues.

PodAffinity/matchLabelKeys: Add tests to switch the feature gate

8 participants

@sanposhiho @k8s-triage-robot @alculquicondor @k8s-ci-robot @salehsedghpour @jiahuif @deads2k @fedebongio