Skip to content

[go] Bump images, dependencies and versions to go 1.22rc2#122889

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
cpanato:update-go-122
Jan 29, 2024
Merged

[go] Bump images, dependencies and versions to go 1.22rc2#122889
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
cpanato:update-go-122

Conversation

@cpanato
Copy link
Copy Markdown
Member

@cpanato cpanato commented Jan 20, 2024

What type of PR is this?

/kind feature
/hold

What this PR does / why we need it:

  • Bump images, dependencies and versions to go 1.22rc2

Which issue(s) this PR fixes:

Part of kubernetes/release#3280

/assign @MadhavJivrajani @liggitt @puerco @xmudrii
cc @kubernetes/release-managers

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes is now built with go 1.22rc2

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 20, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 20, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 20, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 20, 2024
@cpanato cpanato changed the title [go] Bump images, dependencies and versions to go 1.22rc1 [WIP] [go] Bump images, dependencies and versions to go 1.22rc1 Jan 20, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2024
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 20, 2024
@MadhavJivrajani
Copy link
Copy Markdown
Contributor

@thockin FYI ^

@liggitt
Copy link
Copy Markdown
Member

liggitt commented Jan 23, 2024

change lgtm, other than commenting out the line in the dependencies yaml file so the minimum version line passes, is there anything left to merge this?

@thockin
Copy link
Copy Markdown
Member

thockin commented Jan 23, 2024

Thanks! I'll rebase my beast as soon as this merges

@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Jan 23, 2024

change lgtm, other than commenting out the line in the dependencies yaml file so the minimum version line passes, is there anything left to merge this?

i will update it, thanks for the review

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 27, 2024
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Jan 27, 2024

/approve cancel

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2024
Comment thread staging/publishing/rules.yaml Outdated
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 27, 2024
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 28, 2024
@liggitt
Copy link
Copy Markdown
Member

liggitt commented Jan 29, 2024

/lgtm
/approve

can drop the wip / hold if you want

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: f5582822b8020a8ec5cc43866be25612aa22fe42

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2024
@cpanato cpanato changed the title [WIP] [go] Bump images, dependencies and versions to go 1.22rc2 [go] Bump images, dependencies and versions to go 1.22rc2 Jan 29, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2024
@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Jan 29, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0ff6a00 into kubernetes:master Jan 29, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 29, 2024
@cpanato cpanato deleted the update-go-122 branch January 30, 2024 07:37
@thockin
Copy link
Copy Markdown
Member

thockin commented Feb 8, 2024

Now that 1.22.0 is out, is someone bumping to the .0 ?

@dims
Copy link
Copy Markdown
Member

dims commented Feb 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants