Implement KEP-4420: Retry Generate Name#122887
Merged
k8s-ci-robot merged 1 commit intoFeb 15, 2024
Merged
Conversation
Contributor
|
Skipping CI for Draft Pull Request. |
12 tasks
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpbetz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
Changelog suggestion -When the RetryGenerateName feature gate is enabled on the kube-apiserver,
- create requests using generateName are retried automatically by the apiserver when the generated name conflicts with an existing resource name, up to a max limit of 7 retries.
-This feature is in alpha.
+Added an alpha feature behind the `RetryGenerateName` feature gate. When the feature gate is enabled,
+and the API server is handling a **create** request that uses `.metadata.generateName`, then any
+name conflict between the generated name and an existing resource name triggers an automatic server-side
+retry with a different generated name (up to a maximum of 8 attempts). |
Contributor
|
Once this new behavior is targeted at a release and merged / ready to merge, please document the feature gate. |
Contributor
Author
|
/assign @deads2k |
Contributor
|
suggested doc updates seem fine. This fell out shockingly cleanly. Thinking through failure modes
/lgtm |
Contributor
|
LGTM label has been added. DetailsGit tree hash: b44c14f515077e2ee13c7f66777fd6f4f995664f |
Contributor
Author
|
/priority important-longterm |
Contributor
Author
|
/retest |
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
Contributor
Author
|
/retest |
Member
|
/triage accepted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Implements kubernetes/enhancements#4420
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig api-machinery