kube-controller-manager: unit tests WatchListClient feature for client-go#122608
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Jan 18, 2024
Merged
Conversation
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a034fd2 to
f0298b3
Compare
f0298b3 to
d478c15
Compare
d478c15 to
5d3fdc9
Compare
Contributor
|
Just additional tests for #122738 ? No objection, but next time you could get Ben to include them. |
…te for command line options
5d3fdc9 to
8668c7f
Compare
Contributor
Author
Yes, just additional tests, no problem. Although, I prefer to open smaller PRs for easier review. |
Contributor
Author
Contributor
|
LGTM label has been added. DetailsGit tree hash: a22d4a605396d5048626cbd8f8e96e9c1f4c680e |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/triage accepted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Tests whether the
WatchListClient(defined in client-go) is exposed as a command line option forKCMwith its default value set tofalse.We specificity test for
KCMbecause this will be the only component using the watch-list feature for this release (targeted for1.30).Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
requires:
xref: kubernetes/enhancements#3157
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: