Skip to content

[KEP 3960]: graduate PodLifecycleSleepAction to beta#122456

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
AxeZhan:beta3960
Feb 19, 2024
Merged

[KEP 3960]: graduate PodLifecycleSleepAction to beta#122456
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
AxeZhan:beta3960

Conversation

@AxeZhan

@AxeZhan AxeZhan commented Dec 22, 2023

Copy link
Copy Markdown
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

PodLifecycleSleepAction is planned to graduate to beta in 1.30.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

A new metric `lifecycle_handler_sleep_terminated_total` is added to record how many times LifecycleHandler sleep got unexpectedly terminated.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/3960

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 22, 2023
@AxeZhan AxeZhan mentioned this pull request Dec 22, 2023
Closed
14 tasks
@AxeZhan AxeZhan mentioned this pull request Dec 22, 2023
Merged
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubelet area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 22, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2024
@AxeZhan AxeZhan changed the title [WIP] graduate PodLifecycleSleepAction to beta (KEP 3960) graduate PodLifecycleSleepAction to beta (KEP 3960) Jan 18, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2024
@AxeZhan AxeZhan force-pushed the beta3960 branch 6 times, most recently from 242ee34 to 09c6277 Compare January 24, 2024 09:09
thockin
thockin reviewed Feb 15, 2024
View reviewed changes
Comment thread pkg/api/pod/util.go
Comment thread pkg/api/pod/util_test.go Outdated
Comment thread pkg/kubelet/metrics/metrics.go Outdated
Comment thread pkg/registry/core/pod/strategy_test.go
Comment thread test/e2e/common/node/lifecycle_hook.go Outdated
}

var _ = SIGDescribe(feature.PodLifecycleSleepAction, func() {
var _ = SIGDescribe("LifyCycle Hook Sleep Action", func() {

@thockin thockin Feb 15, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelled "Lifecycle" wrong :)

thockin
thockin reviewed Feb 15, 2024
View reviewed changes
Comment thread pkg/api/pod/util_test.go Outdated
Comment thread test/e2e/framework/pod/wait.go Outdated
kannon92
kannon92 reviewed Feb 16, 2024
View reviewed changes
Comment thread test/e2e/common/node/lifecycle_hook.go Outdated
@kannon92

kannon92 commented Feb 16, 2024

Copy link
Copy Markdown
Contributor

Have you thought about how this feature interacts with sidecars?

@AxeZhan

AxeZhan commented Feb 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Have you thought about how this feature interacts with sidecars?

Hmm, nope. I don't see a difference?
In our company, we still use multi containers to do sidecar things, so I'm also not very familiar with sidecar containers.

@kannon92

kannon92 commented Feb 16, 2024

Copy link
Copy Markdown
Contributor

Have you thought about how this feature interacts with sidecars?

Hmm, nope. I don't see a difference? In our company, we still use multi containers to do sidecar things, so I'm also not very familiar with sidecar containers.

I'm talking about the SideCar KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/753-sidecar-containers/README.md

@AxeZhan

AxeZhan commented Feb 16, 2024

Copy link
Copy Markdown
Member Author

I'm talking about the SideCar KEP

Yes, I'm aware of this.

Hmm, nope. I don't see a difference?

Just saying, I think this feature treats the sidecar containers and normal containers the same way, so I'm not sure what do you mean by interacts with sidecars.

@kannon92

kannon92 commented Feb 16, 2024

Copy link
Copy Markdown
Contributor

I'm talking about the SideCar KEP

Yes, I'm aware of this.

Hmm, nope. I don't see a difference?

Just saying, I think this feature treats the sidecar containers and normal containers the same way, so I'm not sure what do you mean by interacts with sidecars.

I was just thinking about some kind of test that makes sure that if someone using the PodLifecycleSleepAction with sidecar feature, do we know what the expected behavior is? I guess that restarting the container on init container and it should use this feature anyway.

@thockin

thockin commented Feb 17, 2024

Copy link
Copy Markdown
Member

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2024
@k8s-ci-robot

k8s-ci-robot commented Feb 17, 2024

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 1b6dffd6771850c7fa6f50c380fd253a453832ab

@k8s-ci-robot

k8s-ci-robot commented Feb 17, 2024

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AxeZhan, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2024
@AxeZhan

AxeZhan commented Feb 17, 2024

Copy link
Copy Markdown
Member Author

I was just thinking about some kind of test that makes sure that if someone using the PodLifecycleSleepAction with sidecar feature, do we know what the expected behavior is? I guess that restarting the container on init container and it should use this feature anyway.

We already have many tests for other handlers(exec, http) here

kubernetes/test/e2e/common/node/lifecycle_hook.go

Line 258 in 1dce896

var _ = SIGDescribe(nodefeature.SidecarContainers, feature.SidecarContainers, "Restartable Init Container Lifecycle Hook", func() {

I can try adding some tests for sleepAction into it later, but I'm not sure how to test two features at same time now.

do we know what the expected behavior is?

The expected behavior should be equal to using exec handler in sidecar containers with command sleep x.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2024
@k8s-ci-robot k8s-ci-robot requested a review from thockin February 19, 2024 11:59
@kannon92

kannon92 commented Feb 19, 2024

Copy link
Copy Markdown
Contributor

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2024
@k8s-ci-robot

k8s-ci-robot commented Feb 19, 2024

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: fc1005696ef7ee94dd43fd23227f6e43edee2c03

@k8s-ci-robot k8s-ci-robot merged commit 3516bc6 into kubernetes:master Feb 19, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@thockin thockin Awaiting requested review from thockin

1 more reviewer

@kannon92 kannon92 kannon92 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kannon92 kannon92

@thockin thockin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

SIG Node: code and documentation PRs
Archived in project

Milestone

v1.30

Development

Successfully merging this pull request may close these issues.

6 participants

@AxeZhan @kannon92 @k8s-ci-robot @thockin @SergeyKanzhelev @bart0sh