Skip to content

Automated cherry pick of #118049: Unset gated pod info timestamp in addToActiveQ#118821

Merged
k8s-ci-robot merged 1 commit into
kubernetes:release-1.27from
helayoty:automated-cherry-pick-of-#118049-upstream-release-1.27
Jun 23, 2023
Merged

Automated cherry pick of #118049: Unset gated pod info timestamp in addToActiveQ#118821
k8s-ci-robot merged 1 commit into
kubernetes:release-1.27from
helayoty:automated-cherry-pick-of-#118049-upstream-release-1.27

Conversation

@helayoty

@helayoty helayoty commented Jun 22, 2023

Copy link
Copy Markdown
Member

Cherry pick of #118049 on release-1.27.

#118049: Unset gated pod info timestamp in addToActiveQ

For details on the cherry pick process, see the cherry pick requests page.

the `pod_scheduling_duration_seconds` metrics won't consider the time when a Pod fails PreEnqueue (like being gated). 

@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jun 22, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 22, 2023
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 22, 2023
@k8s-ci-robot k8s-ci-robot requested a review from chendave June 22, 2023 22:16
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jun 22, 2023
@k8s-ci-robot k8s-ci-robot requested a review from denkensk June 22, 2023 22:16
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 22, 2023
@helayoty helayoty force-pushed the automated-cherry-pick-of-#118049-upstream-release-1.27 branch from f6f2c02 to 087a1d3 Compare June 22, 2023 22:23
@helayoty helayoty added kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 22, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 22, 2023
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty force-pushed the automated-cherry-pick-of-#118049-upstream-release-1.27 branch from 087a1d3 to 62cf5ee Compare June 22, 2023 22:34
@Huang-Wei

Copy link
Copy Markdown
Member

/lgtm
/approve

cc @kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2023
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 5a7cb3bf2111b81685c4a01a5014f348f0bdb936

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2023
@alculquicondor

Copy link
Copy Markdown
Member

/cc @kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team June 23, 2023 11:51

@xmudrii xmudrii left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For RelEng:
/lgtm
/approve

@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 23, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 23, 2023
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: helayoty, Huang-Wei, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0539a6a into kubernetes:release-1.27 Jun 23, 2023
@helayoty helayoty deleted the automated-cherry-pick-of-#118049-upstream-release-1.27 branch June 23, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants