Lookup ENABLE_CLIENT_GO_WATCH_LIST_ALPHA in NewReflectorWithOptions by kkkkun · Pull Request #118235 · kubernetes/kubernetes

kkkkun · 2023-05-24T13:23:41Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

We should change follow codes to NewReflectorWithOptions.

if s := os.Getenv("ENABLE_CLIENT_GO_WATCH_LIST_ALPHA"); len(s) > 0 {
		r.UseWatchList = true
}

Current set in https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/tools/cache/controller.go#L151. If other do not use controller, it's not work when set ENABLE_CLIENT_GO_WATCH_LIST_ALPHA=true.

we can see follow case `request of kubelet when restart`

Pods resource still ListWatch when set ENABLE_CLIENT_GO_WATCH_LIST_ALPHA=true， you can see https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/config/apiserver.go#L66

I0524 12:53:17.548782       1 httplog.go:132] "HTTP" verb="WATCH" URI="/apis/node.k8s.io/v1/runtimeclasses?allowWatchBookmarks=true&resourceVersion=541776794&timeout=5m2s&timeoutSeconds=302&watch=true" latency="3m2.776282077s" userAgent="kubelet/v1.27.0 (linux/amd64) kubernetes/b8e3718" audit-ID="978592e0-f6c1-4895-b498-06d2153a1134" srcIP="x.x.x.x:x" apf_pl="system" apf_fs="system-nodes" apf_iseats=1 apf_fseats=0 apf_additionalLatency="0s" apf_init_latency="212.878µs" apf_execution_time="213.777µs" resp=200
I0524 12:53:17.548803       1 httplog.go:132] "HTTP" verb="WATCH" URI="/api/v1/nodes?allowWatchBookmarks=true&fieldSelector=metadata.name%3Dnode-1&resourceVersion=541708492&timeout=7m10s&timeoutSeconds=430&watch=true" latency="5m48.788466921s" userAgent="kubelet/v1.27.0 (linux/amd64) kubernetes/b8e3718" audit-ID="ac1a48b5-a030-4e8d-bce5-703f6b50fd59" srcIP="x.x.x.x:x" apf_pl="node-high" apf_fs="system-node-high" apf_iseats=1 apf_fseats=0 apf_additionalLatency="0s" apf_init_latency="323.669µs" apf_execution_time="325.137µs" resp=200
I0524 12:53:17.548792       1 httplog.go:132] "HTTP" verb="WATCH" URI="/api/v1/services?allowWatchBookmarks=true&resourceVersion=541487296&timeout=7m53s&timeoutSeconds=473&watch=true" latency="6m26.790128209s" userAgent="kubelet/v1.27.0 (linux/amd64) kubernetes/b8e3718" audit-ID="f3bd04d4-0687-42ef-a392-3e7b7a87db12" srcIP="x.x.x.x:x" apf_pl="system" apf_fs="system-nodes" apf_iseats=1 apf_fseats=0 apf_additionalLatency="0s" apf_init_latency="171.517µs" apf_execution_time="173.588µs" resp=200
I0524 12:53:17.548810       1 httplog.go:132] "HTTP" verb="WATCH" URI="/api/v1/pods?allowWatchBookmarks=true&fieldSelector=spec.nodeName%3Dnode-1&resourceVersion=541596718&timeoutSeconds=571&watch=true" latency="6m32.78753062s" userAgent="kubelet/v1.27.0 (linux/amd64) kubernetes/b8e3718" audit-ID="10b84bc5-0ae1-450a-9771-aa0c5554a3d9" srcIP="x.x.x.x:x" apf_pl="system" apf_fs="system-nodes" apf_iseats=1 apf_fseats=0 apf_additionalLatency="0s" apf_init_latency="243.261µs" apf_execution_time="244.065µs" resp=200
I0524 12:53:17.548831       1 httplog.go:132] "HTTP" verb="WATCH" URI="/apis/storage.k8s.io/v1/csidrivers?allowWatchBookmarks=true&resourceVersion=541601628&timeout=9m51s&timeoutSeconds=591&watch=true" latency="5m36.787954314s" userAgent="kubelet/v1.27.0 (linux/amd64) kubernetes/b8e3718" audit-ID="d157ef07-2730-47e1-bc0a-4bd8f2f77338" srcIP="x.x.x.x:x" apf_pl="system" apf_fs="system-nodes" apf_iseats=1 apf_fseats=0 apf_additionalLatency="0s" apf_init_latency="238.001µs" apf_execution_time="239.784µs" resp=200
I0524 12:53:18.630986       1 httplog.go:132] "HTTP" verb="LIST" URI="/api/v1/pods?fieldSelector=spec.nodeName%3Dnode-1&limit=500&resourceVersion=0" latency="1.204271ms" userAgent="kubelet/v1.27.0 (linux/amd64) kubernetes/b8e3718" audit-ID="0a0005c4-cbd9-4d3d-839e-523166a83e30" srcIP="x.x.x.x:x" apf_pl="system" apf_fs="system-nodes" apf_iseats=10 apf_fseats=0 apf_additionalLatency="0s" apf_execution_time="482.124µs" resp=200

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Signed-off-by: kkkkun <scuzk373x@gmail.com>

k8s-ci-robot · 2023-05-24T13:23:51Z

Hi @kkkkun. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kkkkun · 2023-05-24T13:24:41Z

/release-note-none

kkkkun · 2023-05-24T13:30:23Z

/assign @p0lyn0mial @wojtek-t

p0lyn0mial · 2023-05-25T08:39:02Z

oh, a great find. I like it because it will give us more opportunities to test the feature.

In the future we should probably export the WatchList field as an option.

p0lyn0mial · 2023-05-25T08:41:01Z

/ok-to-test
/test pull-kubernetes-e2e-gce-cos-alpha-features

p0lyn0mial · 2023-05-25T08:41:34Z

/lgtm

k8s-ci-robot · 2023-05-25T08:41:41Z

LGTM label has been added.

Details

Git tree hash: c1b45b49a4b74152c819bf0854445fc9b983e787

p0lyn0mial · 2023-05-25T08:41:51Z

/assign @wojtek-t for approval

k8s-ci-robot · 2023-05-25T08:41:53Z

@p0lyn0mial: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @wojtek-t for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wojtek-t · 2023-05-25T08:50:23Z

/lgtm
/approve

k8s-ci-robot · 2023-05-25T08:50:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kkkkun, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~staging/src/k8s.io/client-go/tools/cache/OWNERS~~ [wojtek-t]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kkkkun · 2023-05-25T09:15:13Z

/test pull-kubernetes-e2e-kind-ipv6

kkkkun · 2023-05-25T09:43:54Z

Should we cherry-pick to 1.27 @p0lyn0mial @wojtek-t ?

p0lyn0mial · 2023-05-25T09:59:26Z

Should we cherry-pick to 1.27 @p0lyn0mial @wojtek-t ?

I don't think it is necessary since this is an alpha feature.

cici37 · 2023-05-30T20:04:45Z

/triage accepted

Should get ENABLE_CLIENT_GO_WATCH_LIST_ALPHA when new reflector

2eed9b4

Signed-off-by: kkkkun <scuzk373x@gmail.com>

k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 24, 2023

k8s-ci-robot requested review from ncdc and wojtek-t May 24, 2023 13:24

k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 24, 2023

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 24, 2023

k8s-ci-robot assigned p0lyn0mial and wojtek-t May 24, 2023

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 25, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2023

k8s-ci-robot merged commit 6911d3b into kubernetes:master May 25, 2023

k8s-ci-robot added this to the v1.28 milestone May 25, 2023

k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 30, 2023

wallrj mentioned this pull request Jul 17, 2024

Reduce load on the Kubernetes API server and reduce the peak memory use of the cert-manager components by enabling the use of the WatchList (Streaming Lists) feature cert-manager/cert-manager#7175

Merged

Conversation

kkkkun commented May 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

we can see follow case request of kubelet when restart

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented May 24, 2023

Uh oh!

kkkkun commented May 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kkkkun commented May 24, 2023

Uh oh!

p0lyn0mial commented May 25, 2023

Uh oh!

p0lyn0mial commented May 25, 2023

Uh oh!

p0lyn0mial commented May 25, 2023

Uh oh!

k8s-ci-robot commented May 25, 2023

Uh oh!

p0lyn0mial commented May 25, 2023

Uh oh!

k8s-ci-robot commented May 25, 2023

Uh oh!

wojtek-t commented May 25, 2023

Uh oh!

k8s-ci-robot commented May 25, 2023

Uh oh!

kkkkun commented May 25, 2023

Uh oh!

kkkkun commented May 25, 2023

Uh oh!

p0lyn0mial commented May 25, 2023

Uh oh!

cici37 commented May 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kkkkun commented May 24, 2023 •

edited

Loading

we can see follow case `request of kubelet when restart`

kkkkun commented May 24, 2023 •

edited

Loading