Skip to content

feature(scheduler): plugin_evaluation_total metric support preScore/score#118025

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
AxeZhan:score-metrics
Jul 5, 2023
Merged

feature(scheduler): plugin_evaluation_total metric support preScore/score#118025
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
AxeZhan:score-metrics

Conversation

@AxeZhan
Copy link
Copy Markdown
Member

@AxeZhan AxeZhan commented May 16, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

"plugin_evaluation_total" metric counts how many times the specific plugin affects the scheduling result while taking Skip status into consideration. Previously it only supports preFilter/filter. With this pr, we can support preScore/score as well.

Which issue(s) this PR fixes:

Fixes #110643

Special notes for your reviewer:

Does this PR introduce a user-facing change?

"plugin_evaluation_total" metric supports prescore/score extension point.
The metric doesn't get incremented when the prescore/score plugin has nothing to do with an incoming Pod.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 16, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 16, 2023

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 16, 2023
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 16, 2023
kerthcet
kerthcet reviewed May 16, 2023
View reviewed changes
Comment thread pkg/scheduler/framework/runtime/instrumented_plugins.go Outdated
sanposhiho
sanposhiho reviewed May 16, 2023
View reviewed changes
Comment thread pkg/scheduler/framework/runtime/framework.go Outdated
@sanposhiho
Copy link
Copy Markdown
Member

sanposhiho commented May 16, 2023

/assign

sanposhiho
sanposhiho reviewed May 16, 2023
View reviewed changes
Comment thread pkg/scheduler/framework/runtime/framework.go Outdated
sanposhiho
sanposhiho reviewed May 16, 2023
View reviewed changes
Comment thread pkg/scheduler/framework/runtime/zs_test.go Outdated
sanposhiho
sanposhiho approved these changes May 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2023
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 16, 2023

LGTM label has been added.

DetailsGit tree hash: ee0d01b4e64e9557be6c92d72d8bc4913fb6bf57

@sanposhiho
Copy link
Copy Markdown
Member

sanposhiho commented May 20, 2023

/assign @Huang-Wei

@AxeZhan AxeZhan requested review from kerthcet and sanposhiho July 5, 2023 05:03
@AxeZhan
Copy link
Copy Markdown
Member Author

AxeZhan commented Jul 5, 2023

/ping @sanposhiho @kerthcet
I think you two can approve now? :)

@sanposhiho
Copy link
Copy Markdown
Member

sanposhiho commented Jul 5, 2023

We should avoid one person giving both /lgtm /approve basically. I'd like to leave /approve to @kerthcet or @Huang-Wei

kerthcet
kerthcet reviewed Jul 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AxeZhan, kerthcet, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 293c1b8 into kubernetes:master Jul 5, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 5, 2023
@jaskaransarkaria jaskaransarkaria mentioned this pull request Jun 5, 2024
Closed
@mochizuki875 mochizuki875 mentioned this pull request Jun 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

1 more reviewer

@kerthcet kerthcet kerthcet left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Huang-Wei Huang-Wei

@kerthcet kerthcet

@sanposhiho sanposhiho

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.28

Development

Successfully merging this pull request may close these issues.

metrics to see which plugins affect to scheduler's decisions in Filter/Score phase

5 participants

@AxeZhan @k8s-ci-robot @sanposhiho @kerthcet @Huang-Wei