klog update#115277
Merged
Merged
Conversation
44da35a to
f5de090
Compare
liggitt
reviewed
Jan 31, 2023
This was referenced Jan 31, 2023
Contributor
Author
|
/lgtm cancel |
4448a61 to
a990eae
Compare
This improves performance of the text formatting and ktesting. Because ktesting no longer buffers messages by default, one unit test needs to ask for that explicitly.
liggitt
reviewed
Mar 1, 2023
| @@ -0,0 +1,173 @@ | |||
| /* | |||
| Copyright 2019 The Kubernetes Authors. | |||
| Copyright 2020 Intel Coporation. | |||
Member
There was a problem hiding this comment.
that's a surprising copyright header (and a typo)
Member
|
/lgtm |
Contributor
|
LGTM label has been added. DetailsGit tree hash: c9cdc4b5ed3296718e3dc01afc0c9c6e8a325136 |
Contributor
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
Contributor
|
@pohly: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
The new klog v2.90.0 contains several performance improvements. To measure those as realistically as possible, logfiles from https://testgrid.k8s.io/sig-instrumentation-tests#kind-json-logging-1.26 were downloaded and the corresponding benchmarks that simulate writing those were updated (included in #115358).
klog v2.90.1 restores immediate discarding of large buffers and extends the ktesting logger.
Here is a comparison using these benchmarks:
Does this PR introduce a user-facing change?