Skip to content

Fix a typo and a misnamed field in CHANGELOG-1.26.md#113843

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Huang-Wei:fix-typo
Nov 14, 2022
Merged

Fix a typo and a misnamed field in CHANGELOG-1.26.md#113843
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Huang-Wei:fix-typo

Conversation

@Huang-Wei
Copy link
Copy Markdown
Member

@Huang-Wei Huang-Wei commented Nov 11, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fix two typos in CHANGELOG-1.26.md

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 11, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 11, 2022

@Huang-Wei: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 11, 2022
@Huang-Wei Huang-Wei mentioned this pull request Nov 11, 2022
Merged
5 tasks
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 11, 2022
Pradumnasaraf
Pradumnasaraf approved these changes Nov 11, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sftim
Copy link
Copy Markdown
Contributor

sftim commented Nov 11, 2022

/retitle Fix a typo and a misnamed field in CHANGELOG-1.26.md

@k8s-ci-robot k8s-ci-robot changed the title Fix typos in CHANGELOG-1.26.md Fix a typo and a misnamed field in CHANGELOG-1.26.md Nov 11, 2022
@Huang-Wei
Copy link
Copy Markdown
Member Author

Huang-Wei commented Nov 11, 2022

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 11, 2022
@dims
Copy link
Copy Markdown
Member

dims commented Nov 14, 2022

/assign @palnabarun @cici37

@cici37
Copy link
Copy Markdown
Contributor

cici37 commented Nov 14, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cici37, Huang-Wei, Pradumnasaraf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 37c7665 into kubernetes:master Nov 14, 2022
@Pradumnasaraf Pradumnasaraf mentioned this pull request Nov 29, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justaugustus justaugustus Awaiting requested review from justaugustus

@Verolop Verolop Awaiting requested review from Verolop

1 more reviewer

@Pradumnasaraf Pradumnasaraf Pradumnasaraf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cici37 cici37

@palnabarun palnabarun

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

[sig-release] Bug Triage
Archived in project

Milestone

v1.26

Development

Successfully merging this pull request may close these issues.

7 participants

@Huang-Wei @k8s-ci-robot @sftim @dims @cici37 @Pradumnasaraf @palnabarun