Skip to content

Promote DS max surge to GA#111194

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
ravisantoshgudimetla:promote-maxSurge-ga
Jul 25, 2022
Merged

Promote DS max surge to GA#111194
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
ravisantoshgudimetla:promote-maxSurge-ga

Conversation

@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor

@ravisantoshgudimetla ravisantoshgudimetla commented Jul 16, 2022 •
edited
Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Promote DaemonSet MaxSurge to GA. This means `--feature-gates=DaemonSetUpdateSurge=true` are not needed on kube-apiserver and kube-controller-manager binaries and they'll be removed soon following policy at https://kubernetes.io/docs/reference/using-api/deprecation-policy/#deprecation

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/1591
- [Usage]: Promote DaemonSet MaxSurge to GA. This means `--feature-gates=DaemonSetUpdateSurge=true` are not needed on kube-apiserver and kube-controller-manager binaries and they'll be removed soon following policy at https://kubernetes.io/docs/reference/using-api/deprecation-policy/#deprecation 
- [Other doc]: https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/daemon-set-v1/#DaemonSetSpec

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 16, 2022
@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor Author

ravisantoshgudimetla commented Jul 16, 2022

/sig apps
/kind feature

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 16, 2022
@k8s-ci-robot k8s-ci-robot requested review from deads2k and kow3ns July 16, 2022 19:12
@k8s-ci-robot k8s-ci-robot added area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 16, 2022
@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Jul 16, 2022

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@ravisantoshgudimetla ravisantoshgudimetla changed the title Promote max surge ga Promote DS max surge ga Jul 18, 2022
@ravisantoshgudimetla ravisantoshgudimetla changed the title Promote DS max surge ga Promote DS max surge to GA Jul 18, 2022
@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor Author

ravisantoshgudimetla commented Jul 18, 2022

/retest

1 similar comment
@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor Author

ravisantoshgudimetla commented Jul 18, 2022

/retest

@atiratree
Copy link
Copy Markdown
Member

atiratree commented Jul 18, 2022

looks good

also we also want to promote this test to conformance once this merges right?

kubernetes/test/e2e/apps/daemon_set.go

Lines 502 to 503 in ff20035

// TODO: This test is expected to be promoted to conformance after the feature is promoted
ginkgo.It("should surge pods onto nodes when spec was updated and update strategy is RollingUpdate", func() {

@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor Author

ravisantoshgudimetla commented Jul 19, 2022

/retest

@leilajal
Copy link
Copy Markdown
Contributor

leilajal commented Jul 19, 2022

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 19, 2022
@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jul 20, 2022

For the changelog entry, please link to kubernetes/enhancements#1591 and not the PR associated with it.

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Jul 20, 2022

/approve

API changes look good to me, the enhancement is in good order, and the docs will be a separate PR.

Are there any changes to tests planned beyond what was described in the KEP?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2022
@rhockenbury rhockenbury mentioned this pull request Jul 21, 2022
Closed
soltysh
soltysh approved these changes Jul 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
from sig-apps pov
/hold
for additional feedback

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ravisantoshgudimetla, smarterclayton, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Jul 21, 2022

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 21, 2022
@ravisantoshgudimetla
Copy link
Copy Markdown
Contributor Author

ravisantoshgudimetla commented Jul 21, 2022 •
edited
Loading

Are there any changes to tests planned beyond what was described in the KEP?

@smarterclayton - As of now, nothing the units are pretty exhaustive. But if you have something in mind, please let us know, and we can add more tests

@sftim - Addressed your comment. PTAL and remove hold if that is what you wanted.

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Jul 25, 2022

Having heard no objections
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2022
@sftim
Copy link
Copy Markdown
Contributor

sftim commented Jul 25, 2022

I'm happy with the changelog here.

@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Jul 25, 2022

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7156c96 into kubernetes:master Jul 25, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 25, 2022
@atiratree atiratree mentioned this pull request Jul 29, 2022
Merged
This was referenced Aug 1, 2022
Merged
Merged
@SataQiu SataQiu mentioned this pull request Dec 11, 2022
Merged
@atiratree atiratree mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@kow3ns kow3ns Awaiting requested review from kow3ns

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.25

Development

Successfully merging this pull request may close these issues.

8 participants

@ravisantoshgudimetla @k8s-triage-robot @atiratree @leilajal @sftim @smarterclayton @k8s-ci-robot @soltysh