Skip to content

Automated cherry pick of #109124: Winkernel proxier cache HNS data to improve syncProxyRules#110701

Merged
k8s-ci-robot merged 2 commits into
kubernetes:release-1.22from
daschott:automated-cherry-pick-of-#109124-upstream-release-1.22
Jun 30, 2022
Merged

Automated cherry pick of #109124: Winkernel proxier cache HNS data to improve syncProxyRules#110701
k8s-ci-robot merged 2 commits into
kubernetes:release-1.22from
daschott:automated-cherry-pick-of-#109124-upstream-release-1.22

Conversation

@daschott

@daschott daschott commented Jun 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Cherry pick of #109124 on release-1.22.

#109124: Winkernel proxier cache HNS data to improve syncProxyRules

For details on the cherry pick process, see the cherry pick requests page.

Reduced time taken to sync proxy rules on Windows kube-proxy with kernelspace mode

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 21, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 21, 2022
@k8s-ci-robot

k8s-ci-robot commented Jun 21, 2022

Copy link
Copy Markdown
Contributor

Hi @daschott. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 21, 2022
@daschott daschott mentioned this pull request Jun 21, 2022
Closed
@daschott

daschott commented Jun 21, 2022

Copy link
Copy Markdown
Contributor Author

/sig windows

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Jun 21, 2022
@daschott

daschott commented Jun 21, 2022

Copy link
Copy Markdown
Contributor Author

Resolves #109162 and regression #110591

@daschott daschott mentioned this pull request Jun 21, 2022
Merged
@jsturtevant

jsturtevant commented Jun 21, 2022

Copy link
Copy Markdown
Contributor

/priority important-soon
/triage accepted
/ok-to-test
/king bug

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 21, 2022
@daschott daschott mentioned this pull request Jun 21, 2022
Closed
@jsturtevant

jsturtevant commented Jun 21, 2022

Copy link
Copy Markdown
Contributor

/test pull-kubernetes-e2e-aks-engine-windows-dockershim-1-22
/test pull-kubernetes-e2e-aks-engine-windows-containerd-1-22

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 22, 2022
@daschott
Winkernel proxier cache HNS data to improve syncProxyRules performance
49ab380 
Resolved issues with proxy rules taking a long time to be synced on Windows, by caching HNS data.

In particular, the following HNS data will be cached for the context of syncProxyRules:
  * HNS endpoints

  * HNS load balancers
@daschott daschott force-pushed the automated-cherry-pick-of-#109124-upstream-release-1.22 branch from 7f8dd03 to 0aba437 Compare June 22, 2022 22:23
@daschott

daschott commented Jun 23, 2022

Copy link
Copy Markdown
Contributor Author

/test pull-kubernetes-e2e-aks-engine-windows-dockershim-1-22
/test pull-kubernetes-e2e-aks-engine-windows-containerd-1-22

@jsturtevant

jsturtevant commented Jun 24, 2022

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2022
@daschott daschott mentioned this pull request Jun 24, 2022
Closed
@sbangari

sbangari commented Jun 27, 2022

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot

k8s-ci-robot commented Jun 27, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daschott, sbangari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2022
@jsturtevant

jsturtevant commented Jun 27, 2022

Copy link
Copy Markdown
Contributor

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team June 27, 2022 22:06
@Verolop

Verolop commented Jun 30, 2022

Copy link
Copy Markdown

/lgtm

@Verolop

Verolop commented Jun 30, 2022

Copy link
Copy Markdown

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 30, 2022
@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 30, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit b74dc9b into kubernetes:release-1.22 Jun 30, 2022
@s7an-it

s7an-it commented Sep 5, 2022

Copy link
Copy Markdown

Is it possible that this change introduced some bug in port-forward from windows machine?
After I applied upgrade that contains this my IDE started to get interrupted on remote debug, is this possible to be connected?

@daschott daschott mentioned this pull request Sep 9, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@madhanrm madhanrm Awaiting requested review from madhanrm

@sbangari sbangari Awaiting requested review from sbangari

Assignees

@jsturtevant jsturtevant

@Verolop Verolop

@sbangari sbangari

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

6 participants

@daschott @k8s-ci-robot @jsturtevant @sbangari @Verolop @s7an-it