Skip to content

Automated cherry pick of #109624: Ignore EndpointSlices that are already marked for deletion#110483

Merged
k8s-ci-robot merged 2 commits into
kubernetes:release-1.23from
aryan9600:automated-cherry-pick-of-#109624-upstream-release-1.23
Jun 9, 2022
Merged

Automated cherry pick of #109624: Ignore EndpointSlices that are already marked for deletion#110483
k8s-ci-robot merged 2 commits into
kubernetes:release-1.23from
aryan9600:automated-cherry-pick-of-#109624-upstream-release-1.23

Conversation

@aryan9600

@aryan9600 aryan9600 commented Jun 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Cherry pick of #109624 on release-1.23.

#109624: Ignore EndpointSlices that are already marked for deletion

For details on the cherry pick process, see the cherry pick requests page.

Cherry pick request: #109624 (comment)

EndpointSlices marked for deletion are now ignored during reconciliation.

aryan9600 added 2 commits June 9, 2022 13:07
@aryan9600
Ignore EndpointSlices that are already marked for deletion
0e1588c 
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
@aryan9600
move the ignore logic higher up to the reconciler
6041228 
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Jun 9, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2022
@k8s-ci-robot

k8s-ci-robot commented Jun 9, 2022

Copy link
Copy Markdown
Contributor

@aryan9600: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

k8s-ci-robot commented Jun 9, 2022

Copy link
Copy Markdown
Contributor

Hi @aryan9600. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 9, 2022
@k8s-ci-robot k8s-ci-robot requested review from khenidak and robscott June 9, 2022 07:38
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 9, 2022
@aryan9600 aryan9600 changed the title Automated cherry pick of #109624: Ignore EndpointSlices that are already marked for Automated cherry pick of #109624: Ignore EndpointSlices that are already marked for deletion Jun 9, 2022
@aryan9600

aryan9600 commented Jun 9, 2022

Copy link
Copy Markdown
Member Author

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 9, 2022
@robscott

robscott commented Jun 9, 2022

Copy link
Copy Markdown
Member

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 9, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2022
@k8s-ci-robot

k8s-ci-robot commented Jun 9, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aryan9600, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2022
@Verolop

Verolop commented Jun 9, 2022

Copy link
Copy Markdown

/lgtm

@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 9, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 9, 2022
@puerco

puerco commented Jun 9, 2022

Copy link
Copy Markdown
Member

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3943991 into kubernetes:release-1.23 Jun 9, 2022
@aryan9600 aryan9600 mentioned this pull request Sep 7, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khenidak khenidak Awaiting requested review from khenidak

@robscott robscott Awaiting requested review from robscott

Assignees

@robscott robscott

@Verolop Verolop

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.23

Development

Successfully merging this pull request may close these issues.

5 participants

@aryan9600 @k8s-ci-robot @robscott @Verolop @puerco