-
Notifications
You must be signed in to change notification settings - Fork 42.9k
pods/eviction does not honor dryRun: trueoption #76943
Copy link
Copy link
Closed
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.priority/critical-urgentHighest priority. Must be actively worked on as someone's top priority right now.Highest priority. Must be actively worked on as someone's top priority right now.sig/api-machineryCategorizes an issue or PR as relevant to SIG API Machinery.Categorizes an issue or PR as relevant to SIG API Machinery.
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.priority/critical-urgentHighest priority. Must be actively worked on as someone's top priority right now.Highest priority. Must be actively worked on as someone's top priority right now.sig/api-machineryCategorizes an issue or PR as relevant to SIG API Machinery.Categorizes an issue or PR as relevant to SIG API Machinery.
What happened:
The pods/eviction REST handler does not check options.DryRun, and actually evicts the pod
/sig api-machinery
/assign @apelisse
/priority important-soon
The integration test for dry run skips all subresources. As part of fixing this, we should fix that test to exercise subresources. There are likely other subresources that do not wire up dry run