What happened:
IsLikelyNotMountPoint() doesn't detect bind mounts of directories on the same fs as /var/lib/kubelet. Local PVs that are directories on the rootfs are most problematic. Similar CSI plugins that expose rootfs directories are also problematic.
This commit identifies some functions that are technically incorrect because they use IsLikelyNotMountPoint() instead of IsNotMountPoint(). However, IsNotMountPoint() is expensive since it has to scan all mount points on the host, so instead of changing the callers to use IsNotMountPoint(), we found other ways to fix the problem.
We should investigate all other uses of IsLikelyNotMountPoint() to see if these cases are handled.
@kubernetes/sig-storage-bugs
/kind bug
What happened:
IsLikelyNotMountPoint() doesn't detect bind mounts of directories on the same fs as /var/lib/kubelet. Local PVs that are directories on the rootfs are most problematic. Similar CSI plugins that expose rootfs directories are also problematic.
This commit identifies some functions that are technically incorrect because they use IsLikelyNotMountPoint() instead of IsNotMountPoint(). However, IsNotMountPoint() is expensive since it has to scan all mount points on the host, so instead of changing the callers to use IsNotMountPoint(), we found other ways to fix the problem.
We should investigate all other uses of IsLikelyNotMountPoint() to see if these cases are handled.
@kubernetes/sig-storage-bugs
/kind bug