-
Notifications
You must be signed in to change notification settings - Fork 42.8k
CCM and Kubelet both write addresses on node object #47155
Copy link
Copy link
Closed
Labels
sig/cluster-lifecycleCategorizes an issue or PR as relevant to SIG Cluster Lifecycle.Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Milestone
Description
When running a kubernetes cluster with Cloud Controller Manager, the node object does not get any addresses other than the internal IP address and Hostname.
After debugging @ublubu and I found that both CCM and kubelet race to set the node address. The kubelet is supposed to back off from setting node address when the cloudprovider is set to external.
This is where kubelet sets node address -
kubernetes/pkg/kubelet/kubelet_node_status.go
Line 968 in b8c9ee8
| kl.setNodeAddress, |
(Kubelet is not supposed to set it, a condition for this check needs to be added)
This is where CCM sets node address -
| _, err = nodeutil.PatchNodeStatus(cnc.kubeClient, types.NodeName(node.Name), node, newNode) |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
sig/cluster-lifecycleCategorizes an issue or PR as relevant to SIG Cluster Lifecycle.Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.