-
Notifications
You must be signed in to change notification settings - Fork 43.2k
Add JSON tags to types.NamespaceName #131313
Copy link
Copy link
Closed
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.sig/api-machineryCategorizes an issue or PR as relevant to SIG API Machinery.Categorizes an issue or PR as relevant to SIG API Machinery.
Metadata
Metadata
Assignees
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.sig/api-machineryCategorizes an issue or PR as relevant to SIG API Machinery.Categorizes an issue or PR as relevant to SIG API Machinery.
Type
Fields
Give feedbackNo fields configured for issues without a type.
What would you like to be added?
Add JSON tags to types.NamespaceName.
Why is this needed?
This a very widely used type. If JSON tags are added then it allows to use this type as part of a custom resource definition.
controller-genexpects JSON tags for all types/fields.There are some projects that already duplicate this type (see here). In our project(s) we also wish to use this type as part of a CRD. Of course its small enough to re-define it but then everyone needs to do the same which i think can be prevented.