Skip to content

VolumeBinding's Score plugin in enabled by default in v1beta3 and v1 config #113705

@Huang-Wei

Description

@Huang-Wei

What happened?

Followed up with @alculquicondor, VolumeBinding Score plugin is enabled only when the feature gate VolumeCapacityPriority is enabled:

func applyFeatureGates(config *v1beta2.Plugins) {
if utilfeature.DefaultFeatureGate.Enabled(features.VolumeCapacityPriority) {
config.Score.Enabled = append(config.Score.Enabled, v1beta2.Plugin{Name: names.VolumeBinding, Weight: pointer.Int32(1)})
}
}

However, with v1beta3 and v1, VolumeBinding Score plugin is no longer feature gated (although its underlying logic is).

What did you expect to happen?

We'd pursue disabling a plugin if the feature gate is disabled. Another thread: #113275 (comment)

How can we reproduce it (as minimally and precisely as possible)?

Run kube-scheduler using a v1beta3 or v1 config, without enabling VolumeCapacityPriority feature gate.

Anything else we need to know?

No response

Kubernetes version

Details
$ kubectl version
# paste output here

Cloud provider

Details N/A

OS version

Details
# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Details

Container runtime (CRI) and version (if applicable)

Details

Related plugins (CNI, CSI, ...) and versions (if applicable)

Details

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.sig/schedulingCategorizes an issue or PR as relevant to SIG Scheduling.

    Type

    No type

    Projects

    Status

    Needs Triage

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions