-
Notifications
You must be signed in to change notification settings - Fork 735
Set the kubelet --hostname-override flag conditionally at kubeadm init time #846
Copy link
Copy link
Closed
kubernetes/kubernetes
#64706Labels
area/UXarea/securitykind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.lifecycle/activeIndicates that an issue or PR is actively being worked on by a contributor.Indicates that an issue or PR is actively being worked on by a contributor.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
Metadata
Metadata
Labels
area/UXarea/securitykind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.lifecycle/activeIndicates that an issue or PR is actively being worked on by a contributor.Indicates that an issue or PR is actively being worked on by a contributor.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
When kubernetes/kubernetes#63887 merges, we should set the kubelet's
--hostname-overrideflag to what's passed to kubeadm via the--node-nameflag conditionallyif cfg.NodeName != nodeutil.GetHostname("")(if the flag differs from the default) at kubeadm init time, incmd/kubeadm/app/phases/kubelet/flags.go.This will automagically fix #584
xref related issue: #822
/assign @liztio
as you're assigned to #584. LMK if you don't have time to do this.