Skip to content

allow pods to reach metric ports running on control plane nodes when using gce alias ip#18052

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
upodroid:reach-metrics-port
Mar 11, 2026
Merged

allow pods to reach metric ports running on control plane nodes when using gce alias ip#18052
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
upodroid:reach-metrics-port

Conversation

@upodroid
Copy link
Copy Markdown
Member

@upodroid upodroid commented Mar 11, 2026

@serathius @hakman

This should fix the GCE scale jobs unable to read metrics from control plane nodes.

Also, this feature should already exist for amazonvpc but it doesn't work.

kops/pkg/model/awsmodel/firewall.go

Line 216 in 3df8618

// For AmazonVPC networking, pods running in Nodes could need to reach pods in master/s
I don't see a all-nodes-to-master-* SG being created for aws cni jobs.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/gcp Issues or PRs related to gcp provider labels Mar 11, 2026
@serathius
Copy link
Copy Markdown
Contributor

serathius commented Mar 11, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2026
@hakman
Copy link
Copy Markdown
Member

hakman commented Mar 11, 2026

Thanks @upodroid.
/approve
/override pull-kops-e2e-k8s-aws-calico

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 11, 2026

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-calico

Details

In response to this:

Thanks @upodroid.
/approve
/override pull-kops-e2e-k8s-aws-calico

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 11, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2026
@k8s-ci-robot k8s-ci-robot merged commit df43863 into kubernetes:master Mar 11, 2026
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olemarkus olemarkus Awaiting requested review from olemarkus

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@serathius serathius

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.36

Development

Successfully merging this pull request may close these issues.

4 participants

@upodroid @serathius @hakman @k8s-ci-robot