Skip to content

chore: fix govet issue in tester.go#17913

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
justinsb:fix_govet_issue
Feb 1, 2026
Merged

chore: fix govet issue in tester.go#17913
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
justinsb:fix_govet_issue

Conversation

@justinsb
Copy link
Copy Markdown
Member

@justinsb justinsb commented Feb 1, 2026

Replace a non-constant format string in fmt.Errorf:

pkg/tester/tester.go:63:25: non-constant format string in call to fmt.Errorf

@justinsb
chore: fix govet issue in tester.go
a814dce 
Replace a non-constant format string in fmt.Errorf:

pkg/tester/tester.go:63:25: non-constant format string in call to fmt.Errorf
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 1, 2026
@justinsb
Copy link
Copy Markdown
Member Author

justinsb commented Feb 1, 2026

Not a release blocker, just setting up our repo to make go vet happy

/milestone v1.36

@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Feb 1, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2026
@hakman
Copy link
Copy Markdown
Member

hakman commented Feb 1, 2026

/override pull-kops-e2e-k8s-aws-calico

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 1, 2026

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-calico

Details

In response to this:

/override pull-kops-e2e-k8s-aws-calico

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit bbccdec into kubernetes:master Feb 1, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.36

Development

Successfully merging this pull request may close these issues.

3 participants

@justinsb @k8s-ci-robot @hakman