openstack: pass through InsecureSkipVerify into openstack components#17908
Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom Feb 2, 2026
Merged
Conversation
Member
Author
|
I think this should into 1.35 /milestone v1.35 |
955072d to
70c82e5
Compare
hakman
approved these changes
Feb 1, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
70c82e5 to
a8d9e0e
Compare
a8d9e0e to
d22e1cf
Compare
If the user has set InsecureSkipVerify in the kops cluster spec for openstack, we should pass that through to the openstack clients we create, so that they honor that setting. We use a "private" environment variable KOPS_OS_TLS_INSECURE_SKIP_VERIFY, because there is no well-known OpenStack environment variable for this purpose.
d22e1cf to
9af8517
Compare
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
fbe1cc0 to
1edae40
Compare
Member
|
/lgtm |
Member
|
/override pull-kops-e2e-k8s-aws-calico |
Contributor
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-calico DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user has set InsecureSkipVerify in the kops cluster spec for openstack,
we should pass that through to the openstack clients we create, so that they
honor that setting.