Skip to content

metal: support dns=none, use API server IP for kops-controller#17884

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
justinsb:metal_should_support_dns_none
Jan 25, 2026
Merged

metal: support dns=none, use API server IP for kops-controller#17884
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
justinsb:metal_should_support_dns_none

Conversation

@justinsb
Copy link
Copy Markdown
Member

The metal support for dns=none would not otherwise be able to find the kops-controller.

We use the API server IP for the kops-controller, as we do on other clouds with dns=none.

The metal support for dns=none would not otherwise be able to find the kops-controller.

We use the API server IP for the kops-controller, as we do on other clouds with dns=none.
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 25, 2026
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 25, 2026
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2026
@k8s-ci-robot k8s-ci-robot merged commit e496f49 into kubernetes:master Jan 25, 2026
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants