Skip to content

Pull cluster name from context in kops version --server#17870

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
rramkumar1:version-name-fix
Jan 22, 2026
Merged

Pull cluster name from context in kops version --server#17870
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
rramkumar1:version-name-fix

Conversation

@rramkumar1
Copy link
Copy Markdown
Contributor

@rramkumar1 rramkumar1 commented Jan 21, 2026 •
edited
Loading

Output from local run:

Client version: 1.35.0-alpha.1 (git-v1.35.0-alpha.1-138-g076ce00ce8)
Using cluster from kubectl context: alias.k8s.local

Last applied server version: 1.34.1

Ref: #16586

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 21, 2026

Hi @rramkumar1. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2026
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 21, 2026
@rramkumar1
Copy link
Copy Markdown
Contributor Author

rramkumar1 commented Jan 21, 2026

/assign @hakman

@hakman
Copy link
Copy Markdown
Member

hakman commented Jan 21, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 21, 2026
@rramkumar1 rramkumar1 changed the title Pull cluster name from context when kops version --server Pull cluster name from context in kops version --server Jan 21, 2026
@justinsb
Copy link
Copy Markdown
Member

justinsb commented Jan 22, 2026

Fixes #16586

Thanks for fixing @rramkumar1

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2026
@k8s-ci-robot k8s-ci-robot merged commit 16a1cdc into kubernetes:master Jan 22, 2026
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Jan 22, 2026
@rifelpet rifelpet mentioned this pull request Apr 13, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman Awaiting requested review from hakman

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@justinsb justinsb

@hakman hakman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.36

Development

Successfully merging this pull request may close these issues.

4 participants

@rramkumar1 @k8s-ci-robot @hakman @justinsb