kubetest2-kops: use ephemeral discovery store for AWS#17809
kubetest2-kops: use ephemeral discovery store for AWS#17809k8s-ci-robot merged 6 commits intokubernetes:masterfrom
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test pull-kops-aws-distro-debian13 |
|
/test pull-kops-aws-distro-debian13 |
|
/test pull-kops-aws-distro-al2023 |
|
@ameukam This needs to be tested with something that enables discovery store. Do we have such job? |
I don't think we have something like that as a presubmit. |
|
/test pull-kops-e2e-cni-cilium |
|
Please ignore the failing tests, let's get the review going first. |
| // Empty the bucket first | ||
| paginator := s3.NewListObjectsV2Paginator(c.s3Client, &s3.ListObjectsV2Input{ | ||
| Bucket: aws.String(bucketName), | ||
| }) |
There was a problem hiding this comment.
It is a good idea, but I would expect that kOps removes all the files from the bucket, otherwise it's a bug.
This approach may hide such issues.
There was a problem hiding this comment.
kOps force delete the S3 buckets at shutdown whether the bucket is empty or not. This is just an extra step to guarantee the bucket is properly deleted.
Potential issues will probably not of the emptiness of the bucket.
Happy to drop this if you think it's unnecessary
There was a problem hiding this comment.
Let's remove it for now, please. Thanks!
a332cc7 to
aa03eb6
Compare
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
aa03eb6 to
43cee3e
Compare
| // Empty the bucket first | ||
| paginator := s3.NewListObjectsV2Paginator(c.s3Client, &s3.ListObjectsV2Input{ | ||
| Bucket: aws.String(bucketName), | ||
| }) |
There was a problem hiding this comment.
Let's remove it for now, please. Thanks!
| d.KopsBinaryPath, "create", "cluster", | ||
| "--name", d.ClusterName, | ||
| "--cloud", d.CloudProvider, | ||
| "--discovery-store", d.discoveryStore(), |
There was a problem hiding this comment.
This needs to be conditionally added if not empty, I guess.
Ensure public access policies can be disabled when the bucket is public Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
bucket. Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
…uster on AWS. Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
Ensure the discovery store S3 bucket is set with KOPS_DISCOVERY_STORE value. Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
6d7230c to
6b15dd3
Compare
|
/test pull-kops-e2e-kubernetes-azure |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override pull-kops-e2e-k8s-gce-ipalias |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-calico, pull-kops-e2e-k8s-gce-ipalias DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Retake of #17520
In addition:
ensure bucket is empty before deletionuse exponential back-off to apply public read policy