Skip to content

Pull CNI plugins from Github#17716

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
ameukam:pull-cni-plugins-from-github
Oct 30, 2025
Merged

Pull CNI plugins from Github#17716
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
ameukam:pull-cni-plugins-from-github

Conversation

@ameukam
Copy link
Copy Markdown
Member

@ameukam ameukam commented Oct 30, 2025

Signed-off-by: Arnaud Meukam ameukam@gmail.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2025
@ameukam
Copy link
Copy Markdown
Member Author

ameukam commented Oct 30, 2025

/test pull-kops-e2e-cni-amazonvpc-ipv6

ameukam
ameukam commented Oct 30, 2025
View reviewed changes
Comment thread pkg/nodemodel/wellknownassets/cni_test.go
hakman
hakman reviewed Oct 30, 2025
View reviewed changes
Comment thread pkg/nodemodel/wellknownassets/cni.go
@ameukam
Pull CNI plugins from Github
43ec310 
Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam
./hack/update-expected.sh executed
da0a995 
Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam ameukam force-pushed the pull-cni-plugins-from-github branch from 6314bd0 to da0a995 Compare October 30, 2025 14:22
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2025
@hakman
Copy link
Copy Markdown
Member

hakman commented Oct 30, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2025
@ameukam
Copy link
Copy Markdown
Member Author

ameukam commented Oct 30, 2025

@hakman how far can we cherry-pick this ?

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 30, 2025 •
edited
Loading

@ameukam: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-cni-amazonvpc-ipv6 6314bd0 link false /test pull-kops-e2e-cni-amazonvpc-ipv6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hakman
Copy link
Copy Markdown
Member

hakman commented Oct 30, 2025

/override pull-kops-e2e-k8s-aws-amazonvpc

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 30, 2025

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-amazonvpc

Details

In response to this:

/override pull-kops-e2e-k8s-aws-amazonvpc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Copy Markdown
Member

hakman commented Oct 30, 2025

@hakman how far can we cherry-pick this ?

@ameukam Let's chat tomorrow?

@k8s-ci-robot k8s-ci-robot merged commit 611e081 into kubernetes:master Oct 30, 2025
27 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Oct 30, 2025
This was referenced Feb 17, 2026
Merged
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman hakman left review comments

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@hakman hakman

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

3 participants

@ameukam @hakman @k8s-ci-robot