Update the node package list only before installing packages#17690
Update the node package list only before installing packages#17690k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
be70230 to
ef90ff9
Compare
|
/assign @justinsb |
|
@justinsb any chance you have some time to look at this? |
| // If it is newer than 10 minutes, we skip apt-get update. | ||
| stat, err := os.Stat("/var/lib/dpkg/status") | ||
| if err != nil { | ||
| klog.Infof("Error getting dpkg status info: %v", err) |
There was a problem hiding this comment.
I feel like we probably should apt-get update in this case (?)
| cmd.Env = env | ||
| output, err := cmd.CombinedOutput() | ||
| if err != nil { | ||
| klog.Infof("Error fetching the latest list of available packages: %v:\n%s", err, string(output)) |
There was a problem hiding this comment.
Nit: klog.Warningf or klog.Errorf ...
And maybe a comment that we don't want to fail the nodeup for this, because it could be a transient mirror failure (for example)
|
Some suggestions but nothing major/blocking. Thanks for doing this! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @justinsb