Skip to content

calico: Don't install Wireguard if disabled#17687

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
hakman:wireguard-disabled
Oct 20, 2025
Merged

calico: Don't install Wireguard if disabled#17687
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
hakman:wireguard-disabled

Conversation

@hakman
Copy link
Copy Markdown
Member

@hakman hakman commented Oct 17, 2025

Some of the presubmits now run with --set=cluster.spec.networking.calico.wireguardEnabled=false, which requires changing from bool to *bool. The change should be transparent for users.
See kubernetes/test-infra#35728.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 17, 2025
@k8s-ci-robot k8s-ci-robot added area/api area/nodeup size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2025
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Oct 17, 2025

/cc @ameukam @rifelpet @justinsb

@hakman hakman force-pushed the wireguard-disabled branch 2 times, most recently from 8792454 to a49fd3f Compare October 17, 2025 12:33
@hakman hakman force-pushed the wireguard-disabled branch from a49fd3f to a8cfe9e Compare October 17, 2025 12:51
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Oct 17, 2025

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2025
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Oct 17, 2025

/test all

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Oct 17, 2025

Investigating why pull-kops-e2e-cni-calico still shows Wireguard being installed.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2025
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@hakman hakman force-pushed the wireguard-disabled branch from a8cfe9e to df18a74 Compare October 17, 2025 15:55
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Oct 17, 2025

/test pull-kops-e2e-gce-cni-calico

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Oct 17, 2025

All good to go now.
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2025
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Oct 17, 2025

/override pull-kops-e2e-gce-cni-calico

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-gce-cni-calico

Details

In response to this:

/override pull-kops-e2e-gce-cni-calico

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ameukam
Copy link
Copy Markdown
Member

ameukam commented Oct 20, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 093cb67 into kubernetes:master Oct 20, 2025
30 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Oct 20, 2025
@hakman hakman deleted the wireguard-disabled branch October 20, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants