Remove unused kubelet flag --pod-infra-container-image#17657
Remove unused kubelet flag --pod-infra-container-image#17657k8s-ci-robot merged 3 commits intokubernetes:masterfrom
--pod-infra-container-image#17657Conversation
1470291 to
c553d26
Compare
|
/approve |
|
/override pull-kops-e2e-cni-kuberouter |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-kuberouter DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
| // PodInfraContainerImage is the image whose network/ipc containers in each pod will use. | ||
| PodInfraContainerImage string `json:"podInfraContainerImage,omitempty" flag:"pod-infra-container-image"` | ||
| // DEPRECATED: Image garbage collector will get sandbox image information from CRI | ||
| PodInfraContainerImage string `json:"-"` |
There was a problem hiding this comment.
No objection to deprecation, but if we remove the field I think we break anyone who was setting this field, in a way that is very hard to recover (like I don't even know if kops edit will load the object). I think in the past we have left the field as-is, but often logged a warning or an error in validation if it is set. Given this is kubeletConfig (and not a top-level configuration), I think an error is reasonable
There was a problem hiding this comment.
In the past we did both, but you are right here, we want to keep the json field for validation purposes.
|
|
||
| { | ||
| // Flag removed in 1.6 | ||
| if k.PodInfraContainerImage != "" { |
There was a problem hiding this comment.
Ah yes, lgtm!
If it was removed in 1.6 maybe we might bet that nobody is setting it! I guess it depends on whether kops edit still works.... But I think if you remove the json tag we also will never hit this because we won't populate the field value?
There was a problem hiding this comment.
Copy/paste omission, it was deprecated in 1.24 and will be removed in 1.35.
The long deprecation is due to lack of image pinning support on containerd side until more recent releases.
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
12b861f to
b5937b2
Compare
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
b5937b2 to
9582069
Compare
|
/approve /retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
1 similar comment
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
|
/override pull-kops-e2e-cni-calico-ipv6 |
|
@hakman: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override pull-kops-e2e-cni-calico-ipv6 |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-calico-ipv6, pull-kops-e2e-cni-cilium-eni, pull-kops-e2e-cni-cilium-etcd, pull-kops-e2e-cni-kuberouter DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override pull-kops-e2e-cni-calico-ipv6 |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-calico-ipv6, pull-kops-e2e-cni-cilium-eni, pull-kops-e2e-cni-cilium-etcd, pull-kops-e2e-cni-kuberouter, pull-kops-e2e-k8s-aws-amazonvpc DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override pull-kops-e2e-cni-calico-ipv6 |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-calico-ipv6, pull-kops-e2e-cni-cilium-eni, pull-kops-e2e-cni-cilium-etcd, pull-kops-e2e-cni-kuberouter, pull-kops-e2e-k8s-aws-amazonvpc DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test all |
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
|
/retest |
|
/override pull-kops-e2e-cni-calico-ipv6 |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-calico-ipv6, pull-kops-e2e-cni-cilium-eni, pull-kops-e2e-cni-cilium-etcd, pull-kops-e2e-cni-kuberouter DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override pull-kops-e2e-cni-calico-ipv6 |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-calico-ipv6, pull-kops-e2e-cni-cilium-eni, pull-kops-e2e-cni-cilium-etcd, pull-kops-e2e-cni-kuberouter DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override pull-kops-e2e-cni-calico |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-calico, pull-kops-e2e-cni-cilium, pull-kops-e2e-cni-cilium-ipv6, pull-kops-e2e-k8s-aws-amazonvpc DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Ref: kubernetes/kubernetes#133779
/cc @rifelpet @ameukam