Skip to content

azure: Use internal K8s API endpoint for cloud-node-manager#17607

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
hakman:azure-ccm-use-internal-api
Sep 8, 2025
Merged

azure: Use internal K8s API endpoint for cloud-node-manager#17607
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
hakman:azure-ccm-use-internal-api

Conversation

@hakman
Copy link
Copy Markdown
Member

@hakman hakman commented Sep 8, 2025

cloud-node-manager needs to be able to remove the node.cloudprovider.kubernetes.io/uninitialized taint, before the CNI can run (e.g. cilium-operator).

/cc @ameukam

@hakman
azure: Use internal K8s API endpoint for cloud-node-manager
4bfa349 
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@k8s-ci-robot k8s-ci-robot requested a review from ameukam September 8, 2025 10:52
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/addons size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2025
@ameukam
Copy link
Copy Markdown
Member

ameukam commented Sep 8, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2025
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Sep 8, 2025

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2025
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Sep 8, 2025

/test pull-kops-e2e-azure-cni-cilium

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Sep 8, 2025

/override pull-kops-e2e-aws-upgrade-k133-ko133-to-klatest-kolatest-many-addons

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 8, 2025

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-aws-upgrade-k133-ko133-to-klatest-kolatest-many-addons

Details

In response to this:

/override pull-kops-e2e-aws-upgrade-k133-ko133-to-klatest-kolatest-many-addons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 754bd2f into kubernetes:master Sep 8, 2025
28 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Oct 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ameukam ameukam Awaiting requested review from ameukam

Assignees

@ameukam ameukam

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hakman @ameukam @k8s-ci-robot