Skip to content

Use only systemd as cgroup driver#17600

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
hakman:systemd-cgroup-driver
Sep 3, 2025
Merged

Use only systemd as cgroup driver#17600
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
hakman:systemd-cgroup-driver

Conversation

@hakman
Copy link
Copy Markdown
Member

@hakman hakman commented Aug 31, 2025

In Kubernetes 1.25, cgroup v2 became GA. Using cgroup v2 in Kubernetes requires the systemd cgroup driver (for both kubelet and the runtime) and cgroupfs is not supported with cgroup v2.

kOps has defaulted to systemd cgroup since Kubernetes 1.20.

kops/nodeup/pkg/model/containerd.go

Lines 501 to 502 in 22687c4

// only enable systemd cgroups for kubernetes >= 1.20
config.SetPath([]string{"plugins", "io.containerd.grpc.v1.cri", "containerd", "runtimes", "runc", "options", "SystemdCgroup"}, cluster.IsKubernetesGTE("1.20"))

/cc @ameukam

@k8s-ci-robot k8s-ci-robot requested a review from ameukam August 31, 2025 09:29
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/api area/nodeup size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 31, 2025
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Aug 31, 2025

/test pull-kops-aws-distro-debian11
/test pull-kops-aws-distro-debian12
/test pull-kops-aws-distro-rhel8
/test pull-kops-aws-distro-rocky9
/test pull-kops-aws-distro-ubuntu2204

@hakman hakman force-pushed the systemd-cgroup-driver branch from fcd410f to f1367b0 Compare August 31, 2025 10:37
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Aug 31, 2025

/test pull-kops-aws-distro-debian11
/test pull-kops-aws-distro-debian12
/test pull-kops-aws-distro-rhel8
/test pull-kops-aws-distro-rocky9
/test pull-kops-aws-distro-ubuntu2204

@ameukam
Copy link
Copy Markdown
Member

ameukam commented Sep 1, 2025

Looks like we need to adjust kubelet's config: containerd/containerd#4857 (comment)

@hakman
Use only systemd as cgroup driver
05a81cf 
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
@hakman hakman force-pushed the systemd-cgroup-driver branch from f1367b0 to 05a81cf Compare September 2, 2025 16:12
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Sep 2, 2025

/test pull-kops-aws-distro-debian11
/test pull-kops-aws-distro-debian12
/test pull-kops-aws-distro-rhel8
/test pull-kops-aws-distro-rocky9
/test pull-kops-aws-distro-ubuntu2204

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Sep 2, 2025

/test pull-kops-aws-distro-debian11
/override pull-kops-e2e-cni-amazonvpc

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 2, 2025

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-amazonvpc

Details

In response to this:

/test pull-kops-aws-distro-debian11
/override pull-kops-e2e-cni-amazonvpc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Sep 2, 2025

/test pull-kops-aws-distro-rhel8

1 similar comment
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Sep 2, 2025

/test pull-kops-aws-distro-rhel8

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Sep 3, 2025

@ameukam I think this is ready now.
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2025
@ameukam
Copy link
Copy Markdown
Member

ameukam commented Sep 3, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit e5b8f24 into kubernetes:master Sep 3, 2025
32 checks passed
@hakman hakman deleted the systemd-cgroup-driver branch September 24, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ameukam ameukam Awaiting requested review from ameukam

Assignees

@ameukam ameukam

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hakman @ameukam @k8s-ci-robot