Skip to content

nodeup: Simplify the template by removing split-commas#17577

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
hakman:simplify-nodeup-template
Aug 25, 2025
Merged

nodeup: Simplify the template by removing split-commas#17577
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
hakman:simplify-nodeup-template

Conversation

@hakman
Copy link
Copy Markdown
Member

@hakman hakman commented Aug 24, 2025

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 24, 2025
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Aug 24, 2025

/test pull-kops-verify-terraform

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Aug 24, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2025
@hakman hakman force-pushed the simplify-nodeup-template branch from 4909d15 to b058094 Compare August 24, 2025 21:26
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Aug 25, 2025

/unhold
/retest

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2025
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Aug 25, 2025

/retest

@ameukam
Copy link
Copy Markdown
Member

ameukam commented Aug 25, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2025
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Aug 25, 2025

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7850359 into kubernetes:master Aug 25, 2025
27 checks passed
@hakman hakman deleted the simplify-nodeup-template branch August 25, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants