Skip to content

etcd-manager: Keep the ImageVolume feature gate for K8s 1.35#17553

Merged
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
hakman:fix-image-volumes
Aug 11, 2025
Merged

etcd-manager: Keep the ImageVolume feature gate for K8s 1.35#17553
k8s-ci-robot merged 2 commits intokubernetes:masterfrom
hakman:fix-image-volumes

Conversation

@hakman
Copy link
Copy Markdown
Member

@hakman hakman commented Aug 11, 2025

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 11, 2025
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Aug 11, 2025 •
edited
Loading

These tests are failing in #17551.
/test pull-kops-e2e-gce-cni-calico
/test pull-kops-e2e-cni-amazonvpc
/test pull-kops-e2e-cni-kuberouter

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Aug 11, 2025

/test pull-kops-e2e-cni-amazonvpc

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 11, 2025

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 11, 2025
@hakman hakman added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2025
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Aug 11, 2025

/test pull-kops-e2e-gce-cni-calico
/test pull-kops-e2e-cni-amazonvpc
/test pull-kops-e2e-cni-kuberouter

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Aug 11, 2025

/retest

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 11, 2025 •
edited
Loading

@hakman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-cni-kuberouter 8c6ac69 link false /test pull-kops-e2e-cni-kuberouter
pull-kops-kubernetes-e2e-ubuntu-gce-build 8c6ac69 link false /test pull-kops-kubernetes-e2e-ubuntu-gce-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Aug 11, 2025

/override pull-kops-e2e-cni-amazonvpc

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 11, 2025

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-amazonvpc

Details

In response to this:

/override pull-kops-e2e-cni-amazonvpc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit fb666c7 into kubernetes:master Aug 11, 2025
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rifelpet rifelpet rifelpet approved these changes

@ameukam ameukam Awaiting requested review from ameukam

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@rifelpet rifelpet

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hakman @k8s-ci-robot @rifelpet