Skip to content

Disallow the use of legacy addons#12064

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
hakman:legacy_addons
Aug 7, 2021
Merged

Disallow the use of legacy addons#12064
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
hakman:legacy_addons

Conversation

@hakman
Copy link
Copy Markdown
Member

@hakman hakman commented Jul 29, 2021

These are no longer maintained and kept around to not break very old versions of kOps.

/cc @olemarkus @johngmyers @rifelpet

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/channels size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 29, 2021
@johngmyers
Copy link
Copy Markdown
Member

johngmyers commented Jul 29, 2021

This is more than just deprecating. This is removing.

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Jul 29, 2021

This is more than just deprecating. This is removing.

Not quite removing, but disallowing the use. They have not been useable for some time.

@johngmyers
Copy link
Copy Markdown
Member

johngmyers commented Jul 29, 2021

1.22 is already deprecating the legacy metrics server and cluster server addons. I wouldn't mind extending that to some or all of the other legacy addons. But this should be announced in release notes and anything further should wait until 1.23 at the earliest.

@justinsb
Copy link
Copy Markdown
Member

justinsb commented Jul 30, 2021

I agree with both of you (I think): this functionality probably is better done via another mechanism now, but we should do so carefully to avoid breaking anyone that might be using it!

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Jul 30, 2021

I agree to with the feedback.
What do you think about disabling it based on k8s version, starting with k8s 1.23?

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Jul 31, 2021

/retest

@olemarkus
Copy link
Copy Markdown
Member

olemarkus commented Aug 1, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8276ec1 into kubernetes:master Aug 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Aug 7, 2021
@hakman hakman deleted the legacy_addons branch October 22, 2021 08:00
@rifelpet rifelpet mentioned this pull request Mar 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olemarkus olemarkus olemarkus approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@olemarkus olemarkus

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/channels area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

5 participants

@hakman @johngmyers @justinsb @olemarkus @k8s-ci-robot