fix: fix ci log failing with logrus#2078
Merged
cdrage merged 2 commits intokubernetes:mainfrom Jan 14, 2026
Merged
Conversation
#### What type of PR is this? <!-- Add one of the following kinds: /kind cleanup /kind documentation /kind feature --> /kind bug The issue was that log.Fatalf expects a constant format string as its first argument, but err.Error() is a variable string that could contain format specifiers like %s, which could cause unexpected behavior. We're going to now use log.Fatal(err) which is the correct way. #### What this PR does / why we need it: Failing PRs (ex. kubernetes#2077) #### Which issue(s) this PR fixes: <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> N/A #### Special notes for your reviewer: N/A Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Member
Author
|
/lgtm |
Contributor
|
@cdrage: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Member
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: fix ci log failing with logrus
What type of PR is this?
/kind bug
The issue was that log.Fatalf expects a constant format string as its first argument, but err.Error() is a variable string that could contain format specifiers like %s, which could cause unexpected behavior.
We're going to now use log.Fatal(err) which is the correct way.
What this PR does / why we need it:
Failing PRs (ex. #2077)
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A
Signed-off-by: Charlie Drage charlie@charliedrage.com