Skip to content

Fix case of FromAs#1993

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
gisostallenberg:patch-1
Mar 13, 2025
Merged

Fix case of FromAs#1993
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
gisostallenberg:patch-1

Conversation

@gisostallenberg
Copy link
Copy Markdown
Contributor

@gisostallenberg gisostallenberg commented Feb 14, 2025

What type of PR is this?

bug

What this PR does / why we need it:

This fixes a warning in newest docker builder

FromAsCasing: 'as' and 'FROM' keywords' casing do not match

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@gisostallenberg
Fix case of FromAs
6910e6f 
This fixes a warning in newest docker builder

```
FromAsCasing: 'as' and 'FROM' keywords' casing do not match
```
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Feb 14, 2025 •
edited
Loading

CLA Signed

  • ✅login: gisostallenberg / (6910e6f)

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 14, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 14, 2025

Welcome @gisostallenberg!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 14, 2025
kundan2707
kundan2707 reviewed Mar 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@kundan2707 kundan2707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good as per docker image file command format

@kundan2707
Copy link
Copy Markdown
Contributor

kundan2707 commented Mar 8, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2025
@cdrage
Copy link
Copy Markdown
Member

cdrage commented Mar 13, 2025

/approve
/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, gisostallenberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit 376ec34 into kubernetes:main Mar 13, 2025
9 checks passed
@BrewTestBot BrewTestBot mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdrage cdrage Awaiting requested review from cdrage

@TessaIO TessaIO Awaiting requested review from TessaIO

1 more reviewer

@kundan2707 kundan2707 kundan2707 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@cdrage cdrage

@kundan2707 kundan2707

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gisostallenberg @k8s-ci-robot @kundan2707 @cdrage