Skip to content

Replaced y with ✓#1975

Merged
cdrage merged 1 commit intokubernetes:mainfrom
alf:patch-1
Dec 20, 2024
Merged

Replaced y with ✓#1975
cdrage merged 1 commit intokubernetes:mainfrom
alf:patch-1

Conversation

@alf
Copy link
Copy Markdown
Contributor

@alf alf commented Dec 18, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Replaces usage of y in the conversion table with ✓.

y is not a valid state according to the glossary.
It is hard to spot the difference between x and y, so fixing this will make it less likely that reads the wrong thing from the table.

If y does not mean ✓ then y should be added to the glossary.
Again, since these marks are hard to differentiate I hope this won't be necessary.

@alf
Replaced y with ✓
4e6a041 
If `y` does not mean ✓ then `y` should be added to the glossary.
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Dec 18, 2024
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Dec 18, 2024 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 18, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 18, 2024

Welcome @alf!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2024
@cdrage
Copy link
Copy Markdown
Member

cdrage commented Dec 18, 2024

Good catch @alf

Sign the k8s CLA and I can merge this in! :)

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alf, TessaIO

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 20, 2024
@cdrage
Copy link
Copy Markdown
Member

cdrage commented Dec 20, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2024
@cdrage cdrage merged commit e81ce2d into kubernetes:main Dec 20, 2024
@cdrage
Copy link
Copy Markdown
Member

cdrage commented Dec 20, 2024

Thanks for the contribution @alf !

@alf
Copy link
Copy Markdown
Contributor Author

alf commented Dec 20, 2024

My pleasure. Small things also matter.

@alf alf deleted the patch-1 branch December 20, 2024 16:08
@BrewTestBot BrewTestBot mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TessaIO TessaIO TessaIO approved these changes

@cdrage cdrage Awaiting requested review from cdrage

Assignees

@cdrage cdrage

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alf @k8s-ci-robot @cdrage @TessaIO